Instant API: tell page whether the browser is capturing key strokes.

chrome/browser/instant/instant_controller.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_
 #define CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 68 matching lines @@
 
   // If the preview is showing search results, commits the preview, calling
   // CommitInstant() on the browser, and returns true. Else, returns false.
   bool CommitIfCurrent(InstantCommitType type);
 
   // The omnibox has lost focus. Commit or discard the preview accordingly.
   void OmniboxLostFocus(gfx::NativeView view_gaining_focus);
 
   // The omnibox has gained focus. Preload the default search engine, in
   // anticipation of the user typing a query.
-  void OmniboxGotFocus();
+  void OmniboxGotFocus(bool focus_is_visible);
 
   // The search mode in the active tab has changed. Pass the message down to
   // the loader which will notify the renderer.
   void SearchModeChanged(const chrome::search::Mode& old_mode,
                          const chrome::search::Mode& new_mode);
 
   // The user switched tabs. Hide the preview if needed.
   void ActiveTabChanged();
 
   // Sets whether Instant should show result previews.
@@ skipping 116 matching lines @@
 
   // See comments on the getter above.
   content::PageTransition last_transition_type_;
 
   // True if the last match passed to Update() was a search (versus a URL).
   bool last_match_was_search_;
 
   // True if the omnibox is focused, false otherwise.
   bool is_omnibox_focused_;
 
+  // True iff the omnibox is invisibly focused. Never true if is_omnibox_focused
+  // is false.
+  bool is_omnibox_invisibly_focused_;

[Jered, 2012/11/28 17:50:16]

Would it make sense to have a single enum here, like OmniboxFocusState { NONE,
INVISIBLE, FOCUS }?

[samarth, 2012/11/28 19:33:09]

We could do that.  The downside is that just checking if the omnibox has focus
becomes complicated (need to check two values).  But that's fine by me if you
prefer that.

[Jered, 2012/11/28 19:56:57]

I think we could just say: omnibox_focus_type_ != NONE, right? This is mostly
aesthetic, I mostly prefer it rather than introducing an "impossible" value.

[samarth, 2012/11/28 22:08:11]

Duh, you're right.  Done.

+
   // The search model mode for the active tab.
   chrome::search::Mode search_mode_;
 
   // Current omnibox bounds.
   gfx::Rect omnibox_bounds_;
 
   // Last bounds passed to the page.
   gfx::Rect last_omnibox_bounds_;
 
   // Timer used to update the bounds of the omnibox.
@@ skipping 17 matching lines @@
 
   // The timestamp at which query editing began. This value is used when the
   // first set of suggestions is processed and cleared when the overlay is
   // hidden.
   base::Time first_interaction_time_;
 
   DISALLOW_COPY_AND_ASSIGN(InstantController);
 };
 
 #endif  // CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_