Instant API: tell page whether the browser is capturing key strokes.

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 348 matching lines @@
   if (event.key_code() == ui::VKEY_CONTROL) {
     // TODO(oshima): investigate if we need to support keyboard with two
     // controls.
     model()->OnControlKeyChanged(false);
     return true;
   }
   return false;
 }
 
 void OmniboxViewViews::HandleMousePressEvent(const ui::MouseEvent& event) {
-  select_all_on_mouse_release_ =
-      (event.IsOnlyLeftMouseButton() || event.IsOnlyRightMouseButton()) &&
+  const bool is_left_or_right_click =
+      (event.IsOnlyLeftMouseButton() || event.IsOnlyRightMouseButton());
+  select_all_on_mouse_release_ = is_left_or_right_click &&
       !textfield_->HasFocus();
-  // Restore caret visibility whenever the user clicks in the the omnibox. This
-  // is not always covered by OnSetFocus() because when clicking while the
-  // omnibox has invisible focus does not trigger a new OnSetFocus() call.
-  model()->SetCaretVisibility(true);
+  // Restore caret visibility whenever the user left or right clicks in the the
+  // omnibox. This is not always covered by OnSetFocus() because when clicking
+  // while the omnibox has invisible focus does not trigger a new OnSetFocus()
+  // call.
+  if (is_left_or_right_click &&
+      (!textfield_->HasFocus() || !model()->is_caret_visible()))

[Peter Kasting, 2012/12/06 06:02:30]

This isn't right... select_all_on_mouse_release_ should contain this condition,
and then we should SetCaretVisibility() iff that member is true.  The way you've
written this, clicking when we have invisible focus doesn't select all, and it
should.

[samarth, 2012/12/06 16:15:50]

Ah ok, makes sense. Done.

+    model()->SetCaretVisibility(true);
 }
 
 void OmniboxViewViews::HandleMouseDragEvent(const ui::MouseEvent& event) {
   select_all_on_mouse_release_ = false;
 }
 
 void OmniboxViewViews::HandleMouseReleaseEvent(const ui::MouseEvent& event) {
   if ((event.IsOnlyLeftMouseButton() || event.IsOnlyRightMouseButton()) &&
       select_all_on_mouse_release_) {
     // Select all in the reverse direction so as not to scroll the caret
@@ skipping 186 matching lines @@
   // the text, or in the middle of composition.
   ui::Range sel;
   textfield_->GetSelectedRange(&sel);
   bool no_inline_autocomplete =
       sel.GetMax() < GetTextLength() || textfield_->IsIMEComposing();
 
   model()->StartAutocomplete(!sel.is_empty(), no_inline_autocomplete);
 }
 
 void OmniboxViewViews::SetFocus() {
+  // In views-implementation, the focus is on textfield rather than OmniboxView.
+  textfield_->RequestFocus();
   // Restore caret visibility if focused explicitly. We need to do this here
   // because if we already have invisible focus, the RequestFocus() call below
   // will short-circuit, preventing us from reaching
   // OmniboxEditModel::OnSetFocus(), which handles restoring visibility when we
   // didn't previously have focus.
   model()->SetCaretVisibility(true);
-  // In views-implementation, the focus is on textfield rather than OmniboxView.
-  textfield_->RequestFocus();
 }
 
 void OmniboxViewViews::ApplyCaretVisibility() {
   if (textfield_->cursor_color() != textfield_->background_color())
     visible_caret_color_ = textfield_->cursor_color();
   // Setting the color of the text cursor (caret) to the background color
   // effectively hides it.
   textfield_->SetCursorColor(model()->is_caret_visible() ?
       visible_caret_color_ : textfield_->background_color());
 }
@@ skipping 375 matching lines @@
   if (!text.empty()) {
     // Record this paste, so we can do different behavior.
     model()->on_paste();
     // Force a Paste operation to trigger the text_changed code in
     // OnAfterPossibleChange(), even if identical contents are pasted into the
     // text box.
     text_before_change_.clear();
     textfield_->ReplaceSelection(text);
   }
 }