Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/html_json_doc/lib/json_to_html.dart

Issue 11413197: Updated json_to_html to be sync. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/html_json_doc/lib/json_to_html.dart
diff --git a/tools/html_json_doc/lib/json_to_html.dart b/tools/html_json_doc/lib/json_to_html.dart
index d25aa4d0b7e654254ef8e7cafbaa575ef98746be..95f7c31444a9cc9c15ca59ed3befb3d048bf6221 100644
--- a/tools/html_json_doc/lib/json_to_html.dart
+++ b/tools/html_json_doc/lib/json_to_html.dart
@@ -66,7 +66,12 @@ Future<bool> convert(Path htmlPath, Path jsonPath) {
// Find html files. (lister)
final lister = htmlDir.list(recursive: false);
+ var pathList = <Path>[];
lister.onFile = (String path) {
+ pathList.add(path);
+ };
+
+ getFile(Path path) {
final name = new Path.fromNative(path).filename;
// Ignore private classes.
@@ -92,21 +97,24 @@ Future<bool> convert(Path htmlPath, Path jsonPath) {
var comments = fileJson[name];
- _convertFile(file, comments);
+ print('BLAH $name');
fileJson.remove(name);
};
lister.onDone = (_) {
+ while(!pathList.isEmpty) {
+ getFile(pathList.removeLast());
+ }
+ print('foo');
- fileJson.forEach((key, _) {
- print('WARNING: the following filename was found in the JSON but not in '
- '${htmlDir.path}:\n"$key"');
- _anyErrors = true;
- });
+ fileJson.forEach((key, _) {
+ print('WARNING: the following filename was found in the JSON but not in '
+ '${htmlDir.path}:\n"$key"');
+ _anyErrors = true;
+ });
- completer.complete(_anyErrors);
- };
Adam 2012/11/27 22:18:05 This closing brace is needed
Andrei Mouravski 2012/11/28 00:28:34 Done.
+ completer.complete(_anyErrors);
return completer.future;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698