Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11413197: Updated json_to_html to be sync. (Closed)

Created:
8 years ago by Andrei Mouravski
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna, financecoding
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updated json_to_html to be sync.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Should work now. #

Patch Set 3 : Better #

Patch Set 4 : Fixed!!! #

Patch Set 5 : Fixed? #

Patch Set 6 : One more try. #

Total comments: 4

Patch Set 7 : Not great, but better. #

Patch Set 8 : Fixed Path. #

Patch Set 9 : Patch for Kathy. #

Patch Set 10 : Please test. #

Patch Set 11 : A shot. #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -68 lines) Patch
M sdk/lib/html/docs/html_docs.json View 1 2 3 4 5 6 7 8 9 10 7 chunks +14 lines, -14 lines 2 comments Download
M tools/html_json_doc/lib/html_to_json.dart View 1 2 3 4 5 6 7 8 9 10 6 chunks +76 lines, -45 lines 5 comments Download
M tools/html_json_doc/lib/json_to_html.dart View 1 2 3 4 5 6 3 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Andrei Mouravski
8 years ago (2012-11-27 22:16:45 UTC) #1
Adam
https://codereview.chromium.org/11413197/diff/1/tools/html_json_doc/lib/json_to_html.dart File tools/html_json_doc/lib/json_to_html.dart (left): https://codereview.chromium.org/11413197/diff/1/tools/html_json_doc/lib/json_to_html.dart#oldcode109 tools/html_json_doc/lib/json_to_html.dart:109: }; This closing brace is needed
8 years ago (2012-11-27 22:18:05 UTC) #2
Adam
https://codereview.chromium.org/11413197/diff/3007/tools/html_json_doc/lib/json_to_html.dart File tools/html_json_doc/lib/json_to_html.dart (right): https://codereview.chromium.org/11413197/diff/3007/tools/html_json_doc/lib/json_to_html.dart#newcode69 tools/html_json_doc/lib/json_to_html.dart:69: var pathList = <Path>[]; Path should be type String ...
8 years ago (2012-11-28 00:13:45 UTC) #3
Andrei Mouravski
Not great, but better. https://codereview.chromium.org/11413197/diff/1/tools/html_json_doc/lib/json_to_html.dart File tools/html_json_doc/lib/json_to_html.dart (left): https://codereview.chromium.org/11413197/diff/1/tools/html_json_doc/lib/json_to_html.dart#oldcode109 tools/html_json_doc/lib/json_to_html.dart:109: }; On 2012/11/27 22:18:05, Adam ...
8 years ago (2012-11-28 00:28:33 UTC) #4
Emily Fortuna
"completed without errors!" :-) just code cleanup suggestions now https://codereview.chromium.org/11413197/diff/3008/sdk/lib/html/docs/html_docs.json File sdk/lib/html/docs/html_docs.json (right): https://codereview.chromium.org/11413197/diff/3008/sdk/lib/html/docs/html_docs.json#newcode1657 sdk/lib/html/docs/html_docs.json:1657: ...
8 years ago (2012-11-28 17:17:30 UTC) #5
Emily Fortuna
8 years ago (2012-11-30 23:27:19 UTC) #6 
https://codereview.chromium.org/11413197/diff/3008/sdk/lib/html/docs/html_doc...
File sdk/lib/html/docs/html_docs.json (right):

https://codereview.chromium.org/11413197/diff/3008/sdk/lib/html/docs/html_doc...
sdk/lib/html/docs/html_docs.json:1385: "DocumentFragment.dart":
There are two DocumentFragment.dart lines now (here and 1389). This doesn't seem
right.

Powered by Google App Engine
This is Rietveld 408576698