Issue 11413188: Move assertion about stopped marking up (again).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11413188: Move assertion about stopped marking up (again). (Closed)

Created:
8 years ago by Michael Starzinger

Modified:
8 years ago

Reviewers:
ulan_google, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move assertion about stopped marking up (again). Weak persistent handle callbacks might trigger nested GCs that in turn can cause marking to be restarted. The assertion needs to hold before firing callbacks only. R=ulan@chromium.org TEST=cctest/test-api --stress-compaction Committed: https://code.google.com/p/v8/source/detail?r=13069

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/heap.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages