Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_string.dart

Issue 11413184: Create specialized versions of getInterceptor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/interceptors.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/string_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/js_string.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/lib/js_string.dart (revision 15381)
+++ sdk/lib/_internal/compiler/implementation/lib/js_string.dart (working copy)
@@ -49,11 +49,18 @@
List<String> split(Pattern pattern) {
checkNull(pattern);
- return stringSplitUnchecked(this, pattern);
+ if (pattern is String) {
+ return JS('JSArray', r'#.split(#)', this, pattern);
+ } else if (pattern is JSSyntaxRegExp) {
+ var re = regExpGetNative(pattern);
+ return JS('JSArray', r'#.split(#)', this, re);
+ } else {
+ throw "String.split(Pattern) UNIMPLEMENTED";
+ }
}
List<String> splitChars() {
- return JS('List', r'#.split("")', this);
+ return JS('JSArray', r'#.split("")', this);
}
bool startsWith(String other) {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/interceptors.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/string_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698