Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/interceptors.dart

Issue 11413184: Create specialized versions of getInterceptor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/lib/interceptors.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/lib/interceptors.dart (revision 15381)
+++ sdk/lib/_internal/compiler/implementation/lib/interceptors.dart (working copy)
@@ -23,29 +23,8 @@
* to emit a call to an intercepted method, that is a method that is
* defined in an interceptor class.
*/
-getInterceptor(object) {
- if (object is String) return stringInterceptor;
- if (isJsArray(object)) return arrayInterceptor;
- if (object is int) return intInterceptor;
- if (object is double) return doubleInterceptor;
- if (object is bool) return boolInterceptor;
- if (object == null) return nullInterceptor;
- if (JS('String', 'typeof #', object) == 'function') {
- return functionInterceptor;
- }
- return objectInterceptor;
-}
+Function getInterceptor;
ahe 2012/11/27 14:29:45 I suggest using this pattern instead: getIntercep
ngeoffray 2012/11/27 15:50:54 Done.
-final arrayInterceptor = const JSArray();
-final boolInterceptor = const JSBool();
-final doubleInterceptor = const JSDouble();
-final intInterceptor = const JSInt();
-final functionInterceptor = const JSFunction();
-final nullInterceptor = const JSNull();
-final numberInterceptor = const JSNumber();
-final stringInterceptor = const JSString();
-final objectInterceptor = const ObjectInterceptor();
-
/**
* The interceptor class for tear-off static methods. Unlike
* tear-off instance methods, tear-off static methods are just the JS

Powered by Google App Engine
This is Rietveld 408576698