Fix incremental marking to be off during heap snapshots.

Fix incremental marking to be off during heap snapshots.

The heap snapshot generator uses the UnreachableObjectsFilter which in
turn messes with marking bits. This requires incremental marking to be
turned off while the snapshot is being generated.

R=verwaest@chromium.org
TEST=cctest/test-heap-profiler --stress-compaction

Committed: https://code.google.com/p/v8/source/detail?r=13066

[Toon Verwaest, 2012-11-27 12:07:26]

lgtm with nit

https://codereview.chromium.org/11413183/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/11413183/diff/1/src/heap.cc#newcode662
src/heap.cc:662: if (!mark_compact_collector()->abort_incremental_marking_ &&
Please make a protected accessor for abort_incremental_marking_;, and maybe give
it a name that describes that incremental marking should not be turned on again.

[Michael Starzinger, 2012-11-27 13:18:10]

Addressed comments. Landing.

https://codereview.chromium.org/11413183/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/11413183/diff/1/src/heap.cc#newcode662
src/heap.cc:662: if (!mark_compact_collector()->abort_incremental_marking_ &&
On 2012/11/27 12:07:26, Toon Verwaest wrote:
> Please make a protected accessor for abort_incremental_marking_;, and maybe
give
> it a name that describes that incremental marking should not be turned on
again.

Done.