Makes IBusConfigClient initialize asynchronous.

Makes IBusConfigClient initialize asynchronous.

IBusConfigClient can not always initialize synchronously, because there is a case that the ibus-config daemon is not running.

BUG=158265
TEST=ran chromeos_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170432

[satorux1, 2012-11-28 06:43:12]

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
File chromeos/dbus/ibus/ibus_config_client.cc (right):

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
chromeos/dbus/ibus/ibus_config_client.cc:187: DLOG(ERROR) << "Invalid response
of NameOwnerChanged.";
Include signal->ToString() ?

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
chromeos/dbus/ibus/ibus_config_client.cc:222: DLOG(ERROR) << "Invalid response
of GetNameOwner.";
Include response->ToString() ?

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
File chromeos/dbus/ibus/ibus_config_client.h (right):

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
chromeos/dbus/ibus/ibus_config_client.h:38: virtual void AsyncInitialize(const
OnIBusConfigReady& on_ready) = 0;
-> InitializeAsync()

Async usually comes at the end of a function name.

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
File chromeos/dbus/ibus/ibus_config_client_unittest.cc (right):

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
chromeos/dbus/ibus/ibus_config_client_unittest.cc:294: void
SycnhronousInitialize() {
InitializeSync() ? Please also add some comment explaining how this function
does initialization synchronously.

[Seigo Nonaka, 2012-11-28 07:00:37]

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
File chromeos/dbus/ibus/ibus_config_client.cc (right):

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
chromeos/dbus/ibus/ibus_config_client.cc:187: DLOG(ERROR) << "Invalid response
of NameOwnerChanged.";
On 2012/11/28 06:43:12, satorux1 wrote:
> Include signal->ToString() ?

Done.

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
chromeos/dbus/ibus/ibus_config_client.cc:222: DLOG(ERROR) << "Invalid response
of GetNameOwner.";
On 2012/11/28 06:43:12, satorux1 wrote:
> Include response->ToString() ?

Done.

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
File chromeos/dbus/ibus/ibus_config_client.h (right):

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
chromeos/dbus/ibus/ibus_config_client.h:38: virtual void AsyncInitialize(const
OnIBusConfigReady& on_ready) = 0;
Sure, done.
On 2012/11/28 06:43:12, satorux1 wrote:
> -> InitializeAsync()
> 
> Async usually comes at the end of a function name.

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
File chromeos/dbus/ibus/ibus_config_client_unittest.cc (right):

https://codereview.chromium.org/11413165/diff/8003/chromeos/dbus/ibus/ibus_co...
chromeos/dbus/ibus/ibus_config_client_unittest.cc:294: void
SycnhronousInitialize() {
On 2012/11/28 06:43:12, satorux1 wrote:
> InitializeSync() ? Please also add some comment explaining how this function
> does initialization synchronously.

Done.

[Seigo Nonaka, 2012-11-28 12:47:53]

Sorry, I updated many Initialize logic in IBusConfig.
I found previous patch doesn't work on actual environment:

1. First, the actual service name is org.freedesktop.DBus for
GetNameOwner/NameOwnerChanged, even if the introspection tells us
org.freedesktop.IBus!!
2. Second, SetNameOwnerChangedCallback function doesn't work for some reason.
Change to use ConnectToSignal instead.
3. GetNameOwner will reply error instead of replying with empty string if the
corresponding owner is not exists.

[Seigo Nonaka, 2012-11-30 03:05:35]

ping? just in case, this is depended from other patch.
I'm happy if you review this first.

Thanks.

[satorux1, 2012-11-30 05:52:58]

LGTM

https://codereview.chromium.org/11413165/diff/14001/chromeos/dbus/ibus/ibus_c...
File chromeos/dbus/ibus/ibus_config_client.cc (right):

https://codereview.chromium.org/11413165/diff/14001/chromeos/dbus/ibus/ibus_c...
chromeos/dbus/ibus/ibus_config_client.cc:26: DLOG_IF(ERROR, !succeeded) <<
"Connect to " << interface << " "
LOG_IF. no need to make it a DLOG?

https://codereview.chromium.org/11413165/diff/14001/chromeos/dbus/ibus/ibus_c...
chromeos/dbus/ibus/ibus_config_client.cc:235: DLOG(ERROR) << "Response is
NULL.";
LOG(ERROR) ? For ERRORs, I think we should use LOG

https://codereview.chromium.org/11413165/diff/14001/chromeos/dbus/ibus/ibus_c...
chromeos/dbus/ibus/ibus_config_client.cc:242: DLOG(ERROR) << "Invalid response
of GetNameOwner."
ditto

[Seigo Nonaka, 2012-11-30 07:36:34]

Thanks! submitting...

https://codereview.chromium.org/11413165/diff/14001/chromeos/dbus/ibus/ibus_c...
File chromeos/dbus/ibus/ibus_config_client.cc (right):

https://codereview.chromium.org/11413165/diff/14001/chromeos/dbus/ibus/ibus_c...
chromeos/dbus/ibus/ibus_config_client.cc:26: DLOG_IF(ERROR, !succeeded) <<
"Connect to " << interface << " "
On 2012/11/30 05:52:58, satorux1 wrote:
> LOG_IF. no need to make it a DLOG?

Done.

https://codereview.chromium.org/11413165/diff/14001/chromeos/dbus/ibus/ibus_c...
chromeos/dbus/ibus/ibus_config_client.cc:235: DLOG(ERROR) << "Response is
NULL.";
On 2012/11/30 05:52:58, satorux1 wrote:
> LOG(ERROR) ? For ERRORs, I think we should use LOG

Done.

https://codereview.chromium.org/11413165/diff/14001/chromeos/dbus/ibus/ibus_c...
chromeos/dbus/ibus/ibus_config_client.cc:242: DLOG(ERROR) << "Invalid response
of GetNameOwner."
On 2012/11/30 05:52:58, satorux1 wrote:
> ditto

Done.

[commit-bot: I haz the power, 2012-11-30 07:36:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11413165/1009

[commit-bot: I haz the power, 2012-11-30 08:17:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11413165/6012

[commit-bot: I haz the power, 2012-11-30 10:02:13]

Change committed as 170432