Issue 11413113: Enable deprecations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11413113: Enable deprecations. (Closed)

Created:
8 years, 1 month ago by Sven Panne

Modified:
8 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Enable deprecations. In addition, use a more common style in the preprocessor condition, making e.g. '-DV8_ENABLE_DEPRECATIONS=0' do the expected thing. Removed a useles Committed: https://code.google.com/p/v8/source/detail?r=13024

Patch Set 1 #

Total comments: 1

Patch Set 2 : Whitespace only #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
	M	include/v8.h	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
	M	src/api.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 1 month ago (2012-11-21 09:47:29 UTC) #2

LGTM with a nit.

https://codereview.chromium.org/11413113/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/11413113/diff/1/include/v8.h#newcode79
include/v8.h:79: 
Drop the second empty newline.

Expand Messages | Collapse Messages