Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 11413091: Fix protoc_java.gypi action dependency. (Closed)

Created:
8 years, 1 month ago by nyquist
Modified:
8 years, 1 month ago
Reviewers:
Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Fix protoc_java.gypi action dependency. The genproto_java action was not necessarily run before the java.gypi included action, so the build would fail. This makes java.gypi depend on the genproto_java stamp file, so the order will now be deterministic. BUG=161587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168838

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comments to clarify #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/protoc_java.gypi View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nyquist
PTAL
8 years, 1 month ago (2012-11-20 17:32:29 UTC) #1
nyquist
PTAL
8 years, 1 month ago (2012-11-20 17:32:30 UTC) #2
Yaron
https://codereview.chromium.org/11413091/diff/1/build/protoc_java.gypi File build/protoc_java.gypi (right): https://codereview.chromium.org/11413091/diff/1/build/protoc_java.gypi#newcode50 build/protoc_java.gypi:50: 'additional_input_paths': ['<(stamp_file)'], This is unused? Shouldn't it be in ...
8 years, 1 month ago (2012-11-20 17:33:53 UTC) #3
nyquist
PTAL https://codereview.chromium.org/11413091/diff/1/build/protoc_java.gypi File build/protoc_java.gypi (right): https://codereview.chromium.org/11413091/diff/1/build/protoc_java.gypi#newcode50 build/protoc_java.gypi:50: 'additional_input_paths': ['<(stamp_file)'], On 2012/11/20 17:33:54, Yaron wrote: > ...
8 years, 1 month ago (2012-11-20 17:47:03 UTC) #4
Yaron
8 years, 1 month ago (2012-11-20 18:00:12 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698