Issue 11413082: Merge 134944 - Web Inspector: Workaround to show shortcuts for panels that hasn't been loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11413082: Merge 134944 - Web Inspector: Workaround to show shortcuts for panels that hasn't been loaded. (Closed)

Created:
8 years, 1 month ago by vsevik

Modified:
8 years, 1 month ago

Reviewers:
commit-queue

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Visibility:
Public.

More Reviews

Description

Merge 134944 - Web Inspector: Workaround to show shortcuts for panels that hasn't been loaded. https://bugs.webkit.org/show_bug.cgi?id=102488 Patch by Eugene Klyuchnikov <eustas.bug@gmail.com>; on 2012-11-16 Reviewed by Vsevolod Vlasov. Panels are lazily loaded / instantiated. Panel constructors register keyboard shortcuts. When user open shortcuts screen all panel should be loaded. Otherwise some shortcuts will be missing. * inspector/front-end/ShortcutsScreen.js: Added callback invokation. * inspector/front-end/inspector.js: Provided callback that loads all panels. TBR=commit-queue@webkit.org BUG=160943 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135262

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	Source/WebCore/inspector/front-end/ShortcutsScreen.js	View		2 chunks	+6 lines, -1 line	0 comments	Download
	M	Source/WebCore/inspector/front-end/inspector.js	View		4 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages