Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 11413075: Beginnings of moving more stuff from build_sdk.py to GYP. (Closed)

Created:
8 years, 1 month ago by binji
Modified:
8 years, 1 month ago
Reviewers:
jeremya, noelallen1
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Beginnings of moving more stuff from build_sdk.py to GYP. Adds a new target to all.gyp: chromium_builder_nacl_sdk Adds a native_client_sdk gyp file: it depends on nacl_core_sdk from the native_client repo, but also builds and copies ppapi libraries to the toolchain directories. Retry of http://codereview.chromium.org/11299081/. Which was a retry of http://codereview.chromium.org/11363045/. Failed both times because of a separate NaCl build issue that was resolved by http://crrev.com/168621. BUG=none TBR=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168921

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +15 lines, -0 lines 1 comment Download
A native_client_sdk/src/build_tools/nacl_ppapi_sdk.gyp View 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jeremya
On a recently pulled build I'm getting the following error: gyp: Unable to find targets ...
8 years, 1 month ago (2012-11-21 01:02:37 UTC) #1
noelallen1
https://codereview.chromium.org/11413075/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/11413075/diff/1/build/all.gyp#newcode353 build/all.gyp:353: { You should conditionally depend nacl_ppapi_sdk and chrome_nacl_win64 to ...
8 years, 1 month ago (2012-11-21 01:33:48 UTC) #2
binji
8 years, 1 month ago (2012-11-21 02:26:01 UTC) #3
This CL has been reverted -- I'll make sure these use cases are covered in my
next try.

Powered by Google App Engine
This is Rietveld 408576698