Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate

Issue 11413071: Deprecating Element.elements for Element.children. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporating review feedback. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate
diff --git a/sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate b/sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate
index 077a8077cae10f650bf2cd971fbae57613e2a7e7..cbdaeab9a3be70da8f0b2b3478e0428c3672e781 100644
--- a/sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate
+++ b/sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate
@@ -53,17 +53,25 @@ class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
elements.addAll(value);
}
+ List<Element> get children => new FilteredElementList(this);
+
+ void set children(Collection<Element> value) {
+ final children = this.children;
+ children.clear();
+ children.addAll(value);
+ }
+
String get outerHTML {
final container = new Element.tag("div");
final SVGElement cloned = this.clone(true);
- container.elements.add(cloned);
+ container.children.add(cloned);
return container.innerHTML;
}
String get innerHTML {
final container = new Element.tag("div");
final SVGElement cloned = this.clone(true);
- container.elements.addAll(cloned.elements);
+ container.children.addAll(cloned.children);
return container.innerHTML;
}
@@ -72,7 +80,7 @@ class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
// Wrap the SVG string in <svg> so that SVGElements are created, rather than
// HTMLElements.
container.innerHTML = '<svg version="1.1">$svg</svg>';
- this.elements = container.elements[0].elements;
+ this.children = container.children[0].children;
}
$!MEMBERS

Powered by Google App Engine
This is Rietveld 408576698