Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 11413067: Merge 134654 - [chromium] Don't let shift-click turn popup into tab. (Closed)

Created:
8 years, 1 month ago by ericu
Modified:
8 years, 1 month ago
Reviewers:
ericu
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 134654 - [chromium] Don't let shift-click turn popup into tab. https://bugs.webkit.org/show_bug.cgi?id=102254 Reviewed by Adam Barth. Change http://trac.webkit.org/changeset/132399 broke shift-click on compose in GMail. We didn't want to change behavior that people were depending on, and this quick fix seems a good compromise between user intent and developer intent. * src/ChromeClientImpl.cpp: (WebKit::updatePolicyForEvent): TBR=ericu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
ericu
8 years, 1 month ago (2012-11-19 18:03:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698