Issue 11413067: Merge 134654 - [chromium] Don't let shift-click turn popup into tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11413067: Merge 134654 - [chromium] Don't let shift-click turn popup into tab. (Closed)

Created:
8 years, 1 month ago by ericu

Modified:
8 years, 1 month ago

Reviewers:
ericu

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Visibility:
Public.

Merge 134654 - [chromium] Don't let shift-click turn popup into tab. https://bugs.webkit.org/show_bug.cgi?id=102254 Reviewed by Adam Barth. Change http://trac.webkit.org/changeset/132399 broke shift-click on compose in GMail. We didn't want to change behavior that people were depending on, and this quick fix seems a good compromise between user intent and developer intent. * src/ChromeClientImpl.cpp: (WebKit::updatePolicyForEvent): TBR=ericu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135173

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	Source/WebKit/chromium/src/ChromeClientImpl.cpp	View		1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)