Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 11413054: [Spellcheck] Don't initialize SpellcheckWordIterator with empty rulesets. (Closed)

Created:
8 years, 1 month ago by groby-ooo-7-16
Modified:
8 years ago
Reviewers:
rpetterson
CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, darin-cc_chromium.org
Visibility:
Public.

Description

[Spellcheck] Don't initialize SpellcheckWordIterator with empty rulesets. R=rlp@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/renderer/spellchecker/spellcheck_worditerator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
groby-ooo-7-16
The source of the magic ASAN bug that killed the "remove cruft" CL.
8 years, 1 month ago (2012-11-17 03:11:32 UTC) #1
rpetterson
lgtm
8 years ago (2012-11-26 19:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11413054/1
8 years ago (2012-11-26 19:27:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11413054/1
8 years ago (2012-11-27 21:02:35 UTC) #4
commit-bot: I haz the power
8 years ago (2012-11-27 21:27:06 UTC) #5
Message was sent while issue was closed.
Change committed as 169761

Powered by Google App Engine
This is Rietveld 408576698