alternate ntp: implement searchbox api for instant overlay to adopt themes

chrome/common/instant_types.h

Index: chrome/common/instant_types.h
diff --git a/chrome/common/instant_types.h b/chrome/common/instant_types.h
index 627a565791f5e76828e00d17f4bb153dc564de7c..fb1de01481142a173277f915aa99cac97d556ab0 100644
--- a/chrome/common/instant_types.h
+++ b/chrome/common/instant_types.h
@@ -93,4 +93,46 @@ enum InstantShownReason {
   INSTANT_SHOWN_ZERO_SUGGESTIONS,
 };
 
+// Specifies information required for NTP instant overlay to adopt the browser's

[sreeram, 2012/11/19 18:12:02]

Nit: instant -> Instant

[kuan, 2012/11/19 22:06:07]

Done.

+// theme.
+struct ThemeBackgroundInfo {
+  ThemeBackgroundInfo();
+  ~ThemeBackgroundInfo();
+
+  // The background color in RGBA format "rgba(R,G,B,A)" where R, G and B are

[palmer, 2012/11/19 18:26:51]

The use of string16s and the formatting requirements make me think you are going
to interpolate these strings directly into CSS/JS. Since these values might come
from an untrustworthy source, That Would Be Bad: arbitrary URLs, XSS and CSS
injection, giant meaningless strings, strings that induce parse failures, and so
on.

It seems to me it would better (more efficient, strongly typed, no parsers
needed, smaller structs, smaller IPC messages) to make most of this struct's
members be ints and enums. Right? For example:

int color_r;
int color_g;
int color_b;
double color_a;

// For selecting the background image. Must contain only alphabetic characters
[or whatever]; write a validator and call it before using it). Not string16;
part of the validation is making sure it is ASCII.
string theme_id;

enum HorizontalAlignment {
    LEFT,
    RIGHT,
    CENTER
};
// uint8 for space efficiency.
uint8 image_horizontal_alignment;

enum VerticalAlignment {
    // ...
};
uint8 image_vertical_alignment;

enum ImageTiling {
    // ...
};
uint8 image_tiling;

// Unsigned because negative heights are meaningless; as small as possible for
space efficiency.
uint16 image_height;

[kuan, 2012/11/19 22:06:07]

i tried w/ uint8, but it's not supported in the ipc macros.

On 2012/11/19 18:26:51, Chris P. wrote:

+  // between 0 and 255 inclusive, and A is a double between 0 and 1 inclusive.
+  // This is the CSS "background-color" format.
+  // Value is always valid.
+  string16 color_rgba;
+
+  // The theme background image url of format
+  // "-webkit-image-set(url(chrome://theme/IDR_THEME_BACKGROUND?<theme_id>) 1x)"
+  // where <theme_id> is the id that identifies the theme.
+  // This is the CSS "background-image" format.
+  // Value is only valid if there's a custom theme background image.
+  string16 image_url;
+
+  // The theme background image horizontal alignment: one of "left", "right",
+  // "center".
+  // This is the horizontal component of the CSS "background-position" format.
+  // Value is only valid if |image_url| is valid.
+  string16 image_horizontal_alignment;
+
+  // The theme background image vertical alignment: one of "top", "bottom",
+  // "center".
+  // This is the vertical component of the CSS "background-position" format.
+  // Value is only valid if |image_url| is valid.
+  string16 image_vertical_alignment;
+
+  // The tiling of the theme background image: one of "no-repeat", "repeat-x",
+  // "repeat-y", "repeat".
+  // This is the CSS "background-repeat" format.
+  // Value is only valid if |image_url| is valid.
+  string16 image_tiling;
+
+  // The theme background image height.
+  // Value is only valid if |image_url| is valid.
+  int image_height;
+};
+
 #endif  // CHROME_COMMON_INSTANT_TYPES_H_