components/plugins/renderer/webview_plugin.cc - Issue 1141283002: Replicate whether a frame is in a document or shadow tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 1141283002: Replicate whether a frame is in a document or shadow tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/html_viewer/html_document.cc ('k') | components/printing/renderer/print_web_view_helper.cc » ('j') | components/printing/renderer/print_web_view_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/webview_plugin.cc

diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc

index 96347fd5b22894d909c842c3dc25a6d2309d1aa9..bc618556448f38e60ad7e1e6913a7ce5a4918c86 100644

--- a/components/plugins/renderer/webview_plugin.cc

+++ b/components/plugins/renderer/webview_plugin.cc

@@ -52,7 +52,7 @@ WebViewPlugin::WebViewPlugin(WebViewPlugin::Delegate* delegate,

// ApplyWebPreferences before making a WebLocalFrame so that the frame sees a

// consistent view of our preferences.

content::RenderView::ApplyWebPreferences(preferences, web_view_);

- web_frame_ = WebLocalFrame::create(this);

+ web_frame_ = WebLocalFrame::create(blink::WebTreeScopeType::Document, this);

web_view_->setMainFrame(web_frame_);

}