Replicate whether a frame is in a document or shadow tree.

content/common/frame_replication_state.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/frame_replication_state.h"
+#include "third_party/WebKit/public/web/WebTreeScopeType.h"
 
 namespace content {
 
+// TODO(dcheng): I'm not sure it's ever right to not pass a tree scope type

[Charlie Reis, 2015/05/19 23:17:10]

I don't see the concern.  Are you worried that someone will call the default
constructor without thinking about whether it's a shadow DOM frame or not?

[dcheng, 2015/05/20 00:09:30]

Yes. I wanted to investigate this in a follow up though.

[Charlie Reis, 2015/05/20 21:38:40]

Can we answer it now?  I feel like this is likely to end up as a permanent TODO
otherwise, without a bug number or reason to come back to it.

[dcheng, 2015/05/21 18:16:16]

While I personally prefer to see this explicitly specified, I guess it's fine in
all the current call sites.

+// here.
 FrameReplicationState::FrameReplicationState()
-    : FrameReplicationState("", SandboxFlags::NONE) {
+    : FrameReplicationState(blink::WebTreeScopeType::Document,
+                            std::string(),
+                            SandboxFlags::NONE) {
 }
 
-FrameReplicationState::FrameReplicationState(const std::string& name,
+FrameReplicationState::FrameReplicationState(blink::WebTreeScopeType scope,
+                                             const std::string& name,
                                              SandboxFlags sandbox_flags)
-    : origin(), sandbox_flags(sandbox_flags), name(name) {
+    : origin(), sandbox_flags(sandbox_flags), name(name), scope(scope) {
 }
 
 FrameReplicationState::~FrameReplicationState() {
 }
 
 }  // namespace content