Add ANGLE platform methods for boolean histograms.

Add ANGLE platform methods for boolean histograms.

Also add in the histogram dashboard info for the new ANGLE
histograms.

BUG=485244
Committed: https://crrev.com/a2295b7f6b4796c4adece570415a1d11eecba3dc
Cr-Commit-Position: refs/heads/master@{#330604}

[Jamie Madill, 2015-05-19 17:16:17]

jmadill@chromium.org changed reviewers:
+ asvitkine@chromium.org, piman@chromium.org

[Jamie Madill, 2015-05-19 17:16:38]

Antone PTAL at the change to the platform, Alexei to the histograms.xml

[Alexei Svitkine (slow), 2015-05-19 17:32:56]

https://codereview.chromium.org/1141263004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1141263004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:12117: +<histogram
name="GPU.ANGLE.SupportsDXGI1_2" units="Boolean">
Please use a more specific enum, like BooleanSupported (add it if it doesn't
exist).

https://codereview.chromium.org/1141263004/diff/1/ui/gl/angle_platform_impl.cc
File ui/gl/angle_platform_impl.cc (right):

https://codereview.chromium.org/1141263004/diff/1/ui/gl/angle_platform_impl.c...
ui/gl/angle_platform_impl.cc:99: UMA_HISTOGRAM_BOOLEAN(name, sample);
You have to expand out the macro, like you do for histgramEnumeration - as the
current macro caches the histogram object and won't work if you log two
different histograms.

You can probably just call histogramEnumeration(name, sample ? 1 : 0, 2); here.

[piman, 2015-05-19 17:54:02]

LGTM one Alexei's comments are addressed.

[Jamie Madill, 2015-05-19 17:55:33]

PTAL Alexei

https://codereview.chromium.org/1141263004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1141263004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:12117: +<histogram
name="GPU.ANGLE.SupportsDXGI1_2" units="Boolean">
On 2015/05/19 17:32:55, Alexei Svitkine wrote:
> Please use a more specific enum, like BooleanSupported (add it if it doesn't
> exist).

Done.

https://codereview.chromium.org/1141263004/diff/1/ui/gl/angle_platform_impl.cc
File ui/gl/angle_platform_impl.cc (right):

https://codereview.chromium.org/1141263004/diff/1/ui/gl/angle_platform_impl.c...
ui/gl/angle_platform_impl.cc:99: UMA_HISTOGRAM_BOOLEAN(name, sample);
On 2015/05/19 17:32:55, Alexei Svitkine wrote:
> You have to expand out the macro, like you do for histgramEnumeration - as the
> current macro caches the histogram object and won't work if you log two
> different histograms.
> 
> You can probably just call histogramEnumeration(name, sample ? 1 : 0, 2);
here.

Done.

[Alexei Svitkine (slow), 2015-05-19 20:23:45]

lgtm

[Jamie Madill, 2015-05-19 20:53:26]

The CQ bit was checked by jmadill@chromium.org

[Jamie Madill, 2015-05-19 20:53:26]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1141263004/#ps20001
(title: "Addressed Alexei's comments")

[commit-bot: I haz the power, 2015-05-19 20:53:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141263004/20001

[commit-bot: I haz the power, 2015-05-19 21:01:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-19 21:01:52]

Patchset 2 (id:??) landed as
https://crrev.com/a2295b7f6b4796c4adece570415a1d11eecba3dc
Cr-Commit-Position: refs/heads/master@{#330604}