chrome/common/extensions/api/platform_keys.idl - Issue 1141253003: chrome.platformKeys: Add filtering by certificate types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/platform_keys.idl

Issue 1141253003: chrome.platformKeys: Add filtering by certificate types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/platform_keys/platform_keys_service.cc ('K') | « chrome/browser/extensions/api/platform_keys/platform_keys_api.cc ('k') | chrome/test/data/extensions/api_test/platform_keys/basic.js » ('j') | chrome/test/data/extensions/api_test/platform_keys/basic.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/platform_keys.idl

diff --git a/chrome/common/extensions/api/platform_keys.idl b/chrome/common/extensions/api/platform_keys.idl

index 9c97ee52eb2caf3f69e3b53f4f03f7e3b2c20939..05460dec144cdc44fa1126b0c9e7f8049e15cdcd 100644

--- a/chrome/common/extensions/api/platform_keys.idl

+++ b/chrome/common/extensions/api/platform_keys.idl

@@ -23,7 +23,6 @@ namespace platformKeys {

enum ClientCertificateType {

rsaSign,

- dssSign,

ecdsaSign

};

@@ -31,7 +30,9 @@ namespace platformKeys {

// See http://tools.ietf.org/html/rfc4346#section-7.4.4 .

dictionary ClientCertificateRequest {

// This field is a list of the types of certificates requested, sorted in

- // order of the server's preference.

+ // order of the server's preference. Only certificates of a type contained

+ // in this list will be retrieved. If <code>certificateTypes</code> is the

+ // empty list, however, all available certificates will be returned.

pneubeck (no reviews) 2015/05/19 10:09:00 s/all available certificate/certificates of any ty

cschuet (SLOW) 2015/05/19 11:36:23 Done.

ClientCertificateType[] certificateTypes;

// List of distinguished names of certificate authorities allowed by the