chrome.platformKeys: Add filtering by certificate types

chrome/test/data/extensions/api_test/platform_keys/basic.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 var systemTokenEnabled = (location.search.indexOf("systemTokenEnabled") != -1);
 var selectedTestSuite = location.hash.slice(1);
 console.log('[SELECTED TEST SUITE] ' + selectedTestSuite +
             ', systemTokenEnable ' + systemTokenEnabled);
@@ skipping 179 matching lines @@
   assertTrue(!!chrome.platformKeys.subtleCrypto().exportKey,
              "No exportKey method.");
   succeed();
 }
 
 var requestAll = {
   certificateTypes: [],
   certificateAuthorities: []
 };
 
+var requestRSA = {

[pneubeck (no reviews), 2015/05/19 10:09:00]

as these two variables are used only once, just make them local to the functions
that use them.

[cschuet (SLOW), 2015/05/19 11:36:23]

Done.

+  certificateTypes: ['rsaSign'],
+  certificateAuthorities: []
+};
+
+var requestECDSA = {
+  certificateTypes: ['ecdsaSign'],
+  certificateAuthorities: []
+};
+
 // Depends on |data|, thus it cannot be created immediately.
 function requestCA1() {
   return {
     certificateTypes: [],
     certificateAuthorities: [data.client_1_issuer_dn.buffer]
   };
 }
 
 function testSelectAllCerts() {
   var expectedCerts = [data.client_1];
@@ skipping 20 matching lines @@
 function testInteractiveSelectNoCerts() {
   assertCertsSelected({interactive: true, request: requestAll},
                       [] /* no certs selected */);
 }
 
 function testInteractiveSelectClient1() {
   assertCertsSelected({interactive: true, request: requestAll},
                       [data.client_1]);
 }
 
-function testMatchResult() {
+function testMatchResultCA1() {
   chrome.platformKeys.selectClientCertificates(
       {interactive: false, request: requestCA1()},
       callbackPass(function(matches) {
         var expectedAlgorithm = {
           modulusLength: 2048,
           name: "RSASSA-PKCS1-v1_5",
           publicExponent: new Uint8Array([0x01, 0x00, 0x01])
         };
         var actualAlgorithm = matches[0].keyAlgorithm;
         assertEq(
             expectedAlgorithm, actualAlgorithm,
             'Member algorithm of Match does not equal the expected algorithm');
       }));
 }
 
+function testMatchResultECDSA() {
+  chrome.platformKeys.selectClientCertificates(
+      {interactive: false, request: requestECDSA},
+      callbackPass(function(matches) {
+        assertEq(
+            0, matches.length,

[pneubeck (no reviews), 2015/05/19 10:09:00]

is this autoformatted?

[cschuet (SLOW), 2015/05/19 11:36:23]

Done.

+            'No matches expected.');
+      }));
+}
+
+function testMatchResultRSA() {
+  chrome.platformKeys.selectClientCertificates(
+      {interactive: false, request: requestRSA},
+      callbackPass(function(matches) {
+        var expectedAlgorithm = {
+          modulusLength: 2048,
+          name: "RSASSA-PKCS1-v1_5",
+          publicExponent: new Uint8Array([0x01, 0x00, 0x01])
+        };
+        var actualAlgorithm = matches[0].keyAlgorithm;
+        assertEq(
+            expectedAlgorithm, actualAlgorithm,
+            'Member algorithm of Match does not equal the expected algorithm');
+      }));
+}
+
 function testGetKeyPairMissingAlgorithName() {
   var keyParams = {
     // This is missing the algorithm name.
     hash: {name: 'SHA-1'}
   };
   try {
     chrome.platformKeys.getKeyPair(
         data.client_1.buffer, keyParams, function(error) {
           fail('getKeyPair call was expected to fail.');
         });
@@ skipping 160 matching lines @@
   // On interactive selectClientCertificates calls, the simulated user does not
   // select any cert.
   basicTests: function() {
     var tests = [
       testStaticMethods,
       testSelectAllCerts,
       testBackgroundNoninteractiveSelect,
       testBackgroundInteractiveSelect,
       testSelectCA1Certs,
       testInteractiveSelectNoCerts,
-      testMatchResult,
+      testMatchResultCA1,
+      testMatchResultECDSA,
+      testMatchResultRSA,
       testGetKeyPairMissingAlgorithName,
       testGetKeyPairRejectsRSAPSS,
       testGetKeyPair,
       testSignNoHash,
       testSignSha1Client1,
     ];
 
     chrome.test.runTests(tests);
   },
 
@@ skipping 23 matching lines @@
       // Verify that client_1 but not client_2 is selected in non-interactive
       // calls.
       testSelectAllReturnsClient1,
     ];
 
     chrome.test.runTests(tests);
   }
 };
 
 setUp(testSuites[selectedTestSuite]);