Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6950)

Unified Diff: chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

Issue 1141253002: [Views] Allow dialog delegates to use a custom padding for the extra view (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/window/dialog_client_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
index d211a534abe14c336f4337304198e32a775ed248..66d5760d2ec6909deac3ea92507e4a19a58b5099 100644
--- a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
@@ -81,6 +81,7 @@ class ExtensionUninstallDialogDelegateView : public views::DialogDelegateView {
private:
// views::DialogDelegate:
views::View* CreateExtraView() override;
+ bool GetExtraViewPadding(int* padding) override;
base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
int GetDefaultDialogButton() const override {
// Default to accept when triggered via chrome://extensions page.
@@ -203,6 +204,13 @@ views::View* ExtensionUninstallDialogDelegateView::CreateExtraView() {
return report_abuse_checkbox_;
}
+bool ExtensionUninstallDialogDelegateView::GetExtraViewPadding(int* padding) {
+ // We want a little more padding between the "report abuse" checkbox and the
+ // buttons.
+ *padding = views::kUnrelatedControlLargeHorizontalSpacing;
+ return true;
+}
+
base::string16 ExtensionUninstallDialogDelegateView::GetDialogButtonLabel(
ui::DialogButton button) const {
return l10n_util::GetStringUTF16((button == ui::DIALOG_BUTTON_OK) ?
« no previous file with comments | « no previous file | ui/views/window/dialog_client_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698