Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1141253002: [Views] Allow dialog delegates to use a custom padding for the extra view (Closed)

Created:
5 years, 7 months ago by Devlin
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Views] Allow dialog delegates to use a custom padding for the extra view Add a new method to allow a DialogDelegate to provide a custom amount to use as the minimum padding between the extra view and the button strip in the dialog. Use this to adjust the padding in the extension uninstall dialog. BUG=441377 Committed: https://crrev.com/90ad13a3b73ceda1500ab42de3d628ef851c2daa Cr-Commit-Position: refs/heads/master@{#330622}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 2 chunks +12 lines, -1 line 0 comments Download
M ui/views/window/dialog_client_view_unittest.cc View 5 chunks +20 lines, -1 line 0 comments Download
M ui/views/window/dialog_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Devlin
Hey Scott - UI review wanted the padding between an extra view checkbox and the ...
5 years, 7 months ago (2015-05-15 18:20:57 UTC) #3
sky
Did you make sure they don't want the extra padding every where?
5 years, 7 months ago (2015-05-18 17:08:47 UTC) #4
Devlin
On 2015/05/18 17:08:47, sky wrote: > Did you make sure they don't want the extra ...
5 years, 7 months ago (2015-05-19 15:53:33 UTC) #5
sky
LGTM
5 years, 7 months ago (2015-05-19 19:48:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141253002/20001
5 years, 7 months ago (2015-05-19 20:53:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-19 21:53:35 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:55:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90ad13a3b73ceda1500ab42de3d628ef851c2daa
Cr-Commit-Position: refs/heads/master@{#330622}

Powered by Google App Engine
This is Rietveld 408576698