Make the cursor have separate mode for disabled mouse events and invisible.

ui/aura/client/cursor_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_AURA_CLIENT_CURSOR_CLIENT_H_
 #define UI_AURA_CLIENT_CURSOR_CLIENT_H_
 
 #include "ui/aura/aura_export.h"
 #include "ui/gfx/native_widget_types.h"
 
 namespace aura {
 class Window;
 namespace client {
 
 // An interface that receives cursor change events.
 class AURA_EXPORT CursorClient {
  public:
   // Notes that |window| has requested the change to |cursor|.
   virtual void SetCursor(gfx::NativeCursor cursor) = 0;
 
-  // Changes the visibility of the cursor.
+  // Changes the visibility of the cursor. Mouse events keep being sent even
+  // when the cursor is invisible,
   virtual void ShowCursor(bool show) = 0;
 
   // Gets whether the cursor is visible.
   virtual bool IsCursorVisible() const = 0;
 
+  // Enables or disables the cursor. When cursor is disabled, no mouse events
+  // are sent.
+  virtual void EnableCursor(bool enabled) = 0;

[sky, 2012/12/17 16:35:38]

This class has inconsistently named methods and the names you're adding are
mildly confusing as well. How about one of:

ShowCursor();
HideCursor();
EnableMouseEvents();
DisableMouseEvents();

or:

SetCursorVisible(bool);
SetMouseEventsEnabled(bool);
SetCursorLocked(bool);

Is the plan that disable mouse events implicitly hides?

[mazda, 2012/12/18 02:49:32]

I change the interface to the former ones.
I don't think of use case where mouse events are disabled and cursor is visible.
But separating the mouse events state and visibility makes the implementation
simpler, so I changed that way.

+
+  // Returns true if the cursor is enabled.
+  virtual bool IsCursorEnabled() const = 0;
+
   // Sets the device scale factor of the cursor.
   virtual void SetDeviceScaleFactor(float device_scale_factor) = 0;
 
   // Locks the cursor change. The cursor type and cursor visibility never change
   // as long as lock is held by anyone.
   virtual void LockCursor() = 0;
 
   // Unlocks the cursor change. If all the locks are released, the cursor type
   // and visibility are restored to the ones set by the lastest call of
   // SetCursor and ShowCursor.
   virtual void UnlockCursor() = 0;
 
  protected:
   virtual ~CursorClient() {}
 };
 
 // Sets/Gets the activation client for the specified window.
 AURA_EXPORT void SetCursorClient(Window* window,
                                  CursorClient* client);
 AURA_EXPORT CursorClient* GetCursorClient(Window* window);
 
 }  // namespace client
 }  // namespace aura
 
 #endif  // UI_AURA_CLIENT_CURSOR_CLIENT_H_