Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: src/frames.cc

Issue 11412310: Issue 2399 part 2: In debugger allow modifying local variable values (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: follow code review Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/frames.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 Object** fixed_base = &Memory::Object_at( 685 Object** fixed_base = &Memory::Object_at(
686 fp() + JavaScriptFrameConstants::kFunctionOffset); 686 fp() + JavaScriptFrameConstants::kFunctionOffset);
687 Object** fixed_limit = &Memory::Object_at(fp()); 687 Object** fixed_limit = &Memory::Object_at(fp());
688 v->VisitPointers(fixed_base, fixed_limit); 688 v->VisitPointers(fixed_base, fixed_limit);
689 689
690 // Visit the return address in the callee and incoming arguments. 690 // Visit the return address in the callee and incoming arguments.
691 IteratePc(v, pc_address(), code); 691 IteratePc(v, pc_address(), code);
692 } 692 }
693 693
694 694
695 void JavaScriptFrame::SetParameterValue(int index, Object* value) const {
696 Memory::Object_at(GetParameterSlot(index)) = value;
697 }
698
699
695 bool JavaScriptFrame::IsConstructor() const { 700 bool JavaScriptFrame::IsConstructor() const {
696 Address fp = caller_fp(); 701 Address fp = caller_fp();
697 if (has_adapted_arguments()) { 702 if (has_adapted_arguments()) {
698 // Skip the arguments adaptor frame and look at the real caller. 703 // Skip the arguments adaptor frame and look at the real caller.
699 fp = Memory::Address_at(fp + StandardFrameConstants::kCallerFPOffset); 704 fp = Memory::Address_at(fp + StandardFrameConstants::kCallerFPOffset);
700 } 705 }
701 return IsConstructFrame(fp); 706 return IsConstructFrame(fp);
702 } 707 }
703 708
704 709
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
1436 ZoneList<StackFrame*> list(10, zone); 1441 ZoneList<StackFrame*> list(10, zone);
1437 for (StackFrameIterator it; !it.done(); it.Advance()) { 1442 for (StackFrameIterator it; !it.done(); it.Advance()) {
1438 StackFrame* frame = AllocateFrameCopy(it.frame(), zone); 1443 StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
1439 list.Add(frame, zone); 1444 list.Add(frame, zone);
1440 } 1445 }
1441 return list.ToVector(); 1446 return list.ToVector();
1442 } 1447 }
1443 1448
1444 1449
1445 } } // namespace v8::internal 1450 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/frames.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698