Issue 11412297: Revert 170694 (requested by acleung on irc, breaks content tests on linux)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412297: Revert 170694 (requested by acleung on irc, breaks content tests on linux) (Closed)

Created:
8 years ago by Nico

Modified:
8 years ago

Reviewers:
acleung

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 170694 (requested by acleung on irc, breaks content tests on linux) > Make sure Java Bridge cleans up all stub object it creates. > > I have been trying to see why the JavaBridgeChannelHost, which is reference counted, sticks around forever. > > Here is what I found: > > When talk back is enabled. Each JavaBridgeChannelHost typically have 5 references to it. 3 of them should be cleaned up by this patch. (see comments in the .cc file) > > BUG=157699 > > > Review URL: https://chromiumcodereview.appspot.com/11359143 TBR=acleung@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170699

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -25 lines)			Patch
	M	content/browser/renderer_host/java/java_bridge_dispatcher_host.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
	M	content/browser/renderer_host/java/java_bridge_dispatcher_host.cc	View		3 chunks	+3 lines, -21 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages