Issue 11412288: Add new stats to local predictor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412288: Add new stats to local predictor (Closed)

Created:
8 years ago by tburkard

Modified:
8 years ago

Reviewers:
Shishir

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add new stats to local predictor R=shishir@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170666

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	chrome/browser/prerender/prerender_local_predictor.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/prerender/prerender_local_predictor.cc	View		2 chunks	+17 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Shishir

8 years ago (2012-12-01 01:33:23 UTC) #2

LGTM

https://codereview.chromium.org/11412288/diff/1/chrome/browser/prerender/prer...
File chrome/browser/prerender/prerender_local_predictor.cc (right):

https://codereview.chromium.org/11412288/diff/1/chrome/browser/prerender/prer...
chrome/browser/prerender/prerender_local_predictor.cc:149: return path ==
"/index.html" || path == "/home.html" ||
Maybe add this to a static set and lookup.

Expand Messages | Collapse Messages