Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: runtime/vm/intermediate_language.h

Issue 11412284: Add result cid to StringFromCharCode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 15607)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -2705,7 +2705,8 @@
class StringFromCharCodeInstr : public TemplateDefinition<1> {
public:
- explicit StringFromCharCodeInstr(Value* char_code) {
+ explicit StringFromCharCodeInstr(Value* char_code,
+ intptr_t cid) : cid_(cid) {
ASSERT(char_code != NULL);
ASSERT(char_code->definition()->IsStringCharCodeAt() &&
(char_code->definition()->AsStringCharCodeAt()->class_id() ==
@@ -2722,13 +2723,15 @@
virtual bool HasSideEffect() const { return false; }
- virtual intptr_t ResultCid() const;
+ virtual intptr_t ResultCid() const { return cid_; }
virtual bool AttributesEqual(Instruction* other) const { return true; }
virtual bool AffectedBySideEffect() const { return false; }
private:
+ const intptr_t cid_;
+
DISALLOW_COPY_AND_ASSIGN(StringFromCharCodeInstr);
};
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698