Issue 11412266: [telemetry] Fix smoothScrollBy scroll distance calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412266: [telemetry] Fix smoothScrollBy scroll distance calculation. (Closed)

Created:
8 years ago by dtu

Modified:
8 years ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Fix smoothScrollBy scroll distance calculation. The smoothness benchmark mean frame times were off because they would attempt to smoothScrollBy to the scrollHeight, but you need to subtract the viewport height to get the correct scrolling distance. Because smoothScrollBy doesn't stop when you hit the bottom of the page, the duration of the scroll gesture was longer than it should be. This made the numbers worse for shorter pages. BUG=162922 TEST=Run a smoothness_benchmark. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170418

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -20 lines)			Patch
	M	tools/telemetry/telemetry/scroll.js	View		4 chunks	+22 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages