sdk/lib/_internal/compiler/implementation/ssa/bailout.dart - Issue 11412245: MalformedType used for all invalid type annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

Issue 11412245: MalformedType used for all invalid type annotations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/resolution/members.dart ('K') | « sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart b/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

index a001ad58ce0099964c2876cb8685c745ae2c725e..fbc2ec1ed82d9da293bb42bf8ff64233f4d2da9e 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

@@ -112,8 +112,10 @@ class SsaTypeGuardInserter extends HGraphVisitor implements OptimizationPhase {

if (source != null) {

DartType sourceType = source.computeType(compiler);

DartType speculatedType = speculativeType.computeType(compiler);

- if (speculatedType != null

- && !compiler.types.isAssignable(speculatedType, sourceType)) {

+ if (speculatedType != null &&

+ !speculatedType.isMalformed &&

+ !sourceType.isMalformed &&

ngeoffray 2012/11/30 12:00:40 I wouldn't bother here. Let it have type guards. T

Johnni Winther 2012/12/04 10:07:17 Done.

+ !compiler.types.isAssignable(speculatedType, sourceType)) {

return false;

}