sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 11412245: MalformedType used for all invalid type annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 11412245: MalformedType used for all invalid type annotations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Bug fixes Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/ssa.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/ssa.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

index 995ac5be3f9c1bd8624359f155513e0b04e98eb3..036d1ac4b4de5a5b01413c5e9f163ad103e1e833 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

@@ -571,7 +571,9 @@ class SsaConstantFolder extends HBaseVisitor implements OptimizationPhase {

&& !RuntimeTypeInformation.hasTypeArguments(type)) {

DartType receiverType = expressionType.computeType(compiler);

if (receiverType != null) {

- if (compiler.types.isSubtype(receiverType, type)) {

+ if (!receiverType.isMalformed &&

+ !type.isMalformed &&

+ compiler.types.isSubtype(receiverType, type)) {

return graph.addConstantBool(true, constantSystem);

} else if (expressionType.isExact()) {

return graph.addConstantBool(false, constantSystem);