MalformedType used for all invalid type annotations.

sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 /**
  * The [ConstantHandler] keeps track of compile-time constants,
  * initializations of global and static fields, and default values of
  * optional parameters.
@@ skipping 112 matching lines @@
       Constant value;
       if (assignment == null) {
         // No initial value.
         value = new NullConstant();
       } else {
         Node right = assignment.arguments.head;
         value =
             compileNodeWithDefinitions(right, definitions, isConst: isConst);
         if (compiler.enableTypeAssertions
             && value != null
             && element.isField()) {

[ngeoffray, 2012/11/30 12:00:40]

Maybe try to have this method call potentiallyCheckType, and pass to that method
the 'isConst' flag?

[Johnni Winther, 2012/12/04 10:07:17]

I found no clean way to refactor.

           DartType elementType = element.computeType(compiler);
           DartType constantType = value.computeType(compiler);
-          if (!constantSystem.isSubtype(compiler, constantType, elementType)) {
+          if (elementType.isMalformed || constantType.isMalformed ||
+              !constantSystem.isSubtype(compiler, constantType, elementType)) {
             if (isConst) {
               MessageKind kind = MessageKind.NOT_ASSIGNABLE;
               compiler.reportError(node, new CompileTimeConstantError(
                   kind, [elementType, constantType]));
             } else {
               // If the field can be lazily initialized, we will throw
               // the exception at runtime.
               value = null;
             }
           }
@@ skipping 559 matching lines @@
     }
     return super.visitSend(send);
   }
 
   void potentiallyCheckType(Node node, Element element, Constant constant) {
     if (compiler.enableTypeAssertions) {
       DartType elementType = element.computeType(compiler);
       DartType constantType = constant.computeType(compiler);
       // TODO(ngeoffray): Handle type parameters.
       if (elementType.element.isTypeVariable()) return;
-      if (!constantSystem.isSubtype(compiler, constantType, elementType)) {
+      if (elementType.isMalformed || constantType.isMalformed ||
+          !constantSystem.isSubtype(compiler, constantType, elementType)) {
         MessageKind kind = MessageKind.NOT_ASSIGNABLE;
         compiler.reportError(node, new CompileTimeConstantError(
             kind, [elementType, constantType]));
       }
     }
   }
 
   void updateFieldValue(Node node, Element element, Constant constant) {
     potentiallyCheckType(node, element, constant);
     fieldValues[element] = constant;
@@ skipping 119 matching lines @@
             // Use the default value.
             fieldValue = compiler.compileConstant(field);
           }
           jsNewArguments.add(fieldValue);
         },
         includeBackendMembers: true,
         includeSuperMembers: true);
     return jsNewArguments;
   }
 }