sdk/lib/_internal/compiler/implementation/ssa/ssa.dart - Issue 11412245: MalformedType used for all invalid type annotations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/_internal/compiler/implementation/ssa/ssa.dart

Issue 11412245: MalformedType used for all invalid type annotations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Bug fixes Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/types.dart » ('j') | sdk/lib/_internal/compiler/implementation/typechecker.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library ssa;	5 library ssa;

6	6

7 import '../closure.dart';	7 import '../closure.dart';

8 import '../js/js.dart' as js;	8 import '../js/js.dart' as js;

9 import '../dart2jslib.dart' hide Selector;	9 import '../dart2jslib.dart' hide Selector;

10 import '../source_file.dart';	10 import '../source_file.dart';

(...skipping 17 matching lines...) Expand all Loading...
28 part 'codegen_helpers.dart';	28 part 'codegen_helpers.dart';

29 part 'js_names.dart';	29 part 'js_names.dart';

30 part 'nodes.dart';	30 part 'nodes.dart';

31 part 'optimize.dart';	31 part 'optimize.dart';

32 part 'types.dart';	32 part 'types.dart';

33 part 'types_propagation.dart';	33 part 'types_propagation.dart';

34 part 'validate.dart';	34 part 'validate.dart';

35 part 'variable_allocator.dart';	35 part 'variable_allocator.dart';

36 part 'value_range_analyzer.dart';	36 part 'value_range_analyzer.dart';

37 part 'value_set.dart';	37 part 'value_set.dart';

	38

	39 String fetchReasonsFromMalformedType(DartType type) {
	ahe 2012/11/30 15:44:07 For consistency, please move this function to anot For consistency, please move this function to another file. Also, it really isn't related to SSA, so perhaps it belongs in a different library? Johnni Winther 2012/12/04 10:07:17 Moved to typechecker.dart Show quoted text On 2012/11/30 15:44:07, ahe wrote: > For consistency, please move this function to another file. > > Also, it really isn't related to SSA, so perhaps it belongs in a different > library? Moved to typechecker.dart
	40 var reasons = new List<String>();

	41 type.forEachMalformedType((MalformedType malformedType) {

	42 ErroneousElement error = malformedType.element;

	43 Message message = error.messageKind.message(error.messageArguments);

	44 reasons.add(message.toString());

	45 return true;

	46 });

	47 return Strings.join(reasons, ', ');
	ahe 2012/11/30 15:44:07 I'm not sure it is a good idea to concatenate stri I'm not sure it is a good idea to concatenate strings that are likely to be translated. Johnni Winther 2012/12/04 10:07:17 Added a TODO. Show quoted text On 2012/11/30 15:44:07, ahe wrote: > I'm not sure it is a good idea to concatenate strings that are likely to be > translated. Added a TODO.
	48 }

OLD	NEW