MalformedType used for all invalid type annotations.

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * A special element for the extra parameter taken by intercepted
  * methods. We need to override [Element.computeType] because our
  * optimizers may look at its declared type.
@@ skipping 89 matching lines @@
   }
 
   Element getExceptionUnwrapper() {
     return compiler.findHelper(const SourceString('unwrapException'));
   }
 
   Element getThrowRuntimeError() {
     return compiler.findHelper(const SourceString('throwRuntimeError'));
   }
 
+  Element getThrowMalformedSubtypeError() {
+    return compiler.findHelper(
+        const SourceString('throwMalformedSubtypeError'));
+  }
+
   Element getThrowAbstractClassInstantiationError() {
     return compiler.findHelper(
         const SourceString('throwAbstractClassInstantiationError'));
   }
 
   Element getClosureConverter() {
     return compiler.findHelper(const SourceString('convertDartClosureToJS'));
   }
 
   Element getTraceFromException() {
@@ skipping 2521 matching lines @@
       TypeAnnotation typeAnnotation = argument.asTypeAnnotation();
       bool isNot = false;
       // TODO(ngeoffray): Duplicating pattern in resolver. We should
       // add a new kind of node.
       if (typeAnnotation == null) {
         typeAnnotation = argument.asSend().receiver;
         isNot = true;
       }
 
       DartType type = elements.getType(typeAnnotation);
+      if (type.isMalformed) {
+        String reasons = fetchReasonsFromMalformedType(type);
+        if (compiler.enableTypeAssertions) {
+          generateMalformedSubtypeError(node, expression, type, reasons);
+        } else {
+          generateRuntimeError(node, '$type is malformed: $reasons');
+        }
+        return;
+      }
       HInstruction typeInfo = null;
       if (RuntimeTypeInformation.hasTypeArguments(type)) {
         pushInvokeHelper1(interceptors.getGetRuntimeTypeInfo(), expression);
         typeInfo = pop();
       }
       if (type.element.isTypeVariable()) {
         // TODO(karlklose): We currently answer true to any is check
         // involving a type variable -- both is T and is !T -- until
         // we have a proper implementation of reified generics.
         stack.add(graph.addConstantBool(true, constantSystem));
@@ skipping 391 matching lines @@
       }
     } else {
       target = new HInvokeSuper(inputs);
       add(target);
       inputs = <HInstruction>[target];
       addDynamicSendArgumentsToList(node, inputs);
       push(new HInvokeClosure(selector, inputs));
     }
   }
 
+  /**
+   * Documentation wanted -- johnniwinther
+   *
+   * Invariant: [argument] must not be malformed in checked mode.
+   */
   HInstruction analyzeTypeArgument(DartType argument, Node currentNode) {
-    if (argument == compiler.types.dynamicType) {
+    assert(invariant(currentNode,
+                     !compiler.enableTypeAssertions || !argument.isMalformed,
+                     message: '$argument is malformed in checked mode'));
+    if (argument == compiler.types.dynamicType || argument.isMalformed) {
       // Represent [dynamic] as [null].
       return graph.addConstantNull(constantSystem);
     }
 
     // These variables are shared between invocations of the helper methods.
     HInstruction typeInfo;
     StringBuffer template = new StringBuffer();
     List<HInstruction> inputs = <HInstruction>[];
 
     /**
@@ skipping 107 matching lines @@
     add(typeInfo);
 
     // Set the runtime type information on the object.
     Element typeInfoSetterElement = interceptors.getSetRuntimeTypeInfo();
     HInstruction typeInfoSetter = new HStatic(typeInfoSetterElement);
     add(typeInfoSetter);
     add(new HInvokeStatic(
         <HInstruction>[typeInfoSetter, newObject, typeInfo]));
   }
 
+  /**
+   * Documentation wanted -- johnniwinther
+   *
+   * Invariant: [type] must not be malformed in checked mode.
+   */
   visitNewSend(Send node, InterfaceType type) {
+    assert(invariant(node,
+                     !compiler.enableTypeAssertions || !type.isMalformed,
+                     message: '$type is malformed in checked mode'));
     bool isListConstructor = false;
     computeType(element) {
       Element originalElement = elements[node];
       if (identical(originalElement.getEnclosingClass(), compiler.listClass)) {
         isListConstructor = true;
         if (node.arguments.isEmpty) {
           return HType.EXTENDABLE_ARRAY;
         } else {
           return HType.MUTABLE_ARRAY;
         }
@@ skipping 219 matching lines @@
     FunctionSignature signature = function.computeSignature(compiler);
     signature.forEachParameter((Element parameter) {
       existingArguments.add(parameter.name.slowToString());
     });
     generateThrowNoSuchMethod(diagnosticNode,
                               function.name.slowToString(),
                               argumentNodes: argumentNodes,
                               existingArguments: existingArguments);
   }
 
+  void generateMalformedSubtypeError(Node node, HInstruction value,
+                                     DartType type, String reasons) {
+    HInstruction typeString = addConstantString(node, type.toString());
+    HInstruction reasonsString = addConstantString(node, reasons);
+    Element helper = interceptors.getThrowMalformedSubtypeError();
+    pushInvokeHelper3(helper, value, typeString, reasonsString);
+  }
+
   visitNewExpression(NewExpression node) {
     Element element = elements[node.send];
-    if (!Elements.isErroneousElement(element) &&
-        !Elements.isMalformedElement(element)) {
+    if (!Elements.isErroneousElement(element)) {
       FunctionElement function = element;
       element = function.redirectionTarget;
     }
     if (Elements.isErroneousElement(element)) {
       ErroneousElement error = element;
       if (error.messageKind == MessageKind.CANNOT_FIND_CONSTRUCTOR) {
         generateThrowNoSuchMethod(node.send,
                                   getTargetName(error, 'constructor'),
                                   argumentNodes: node.send.arguments);
-      } else if (error.messageKind == MessageKind.CANNOT_RESOLVE) {
+      } else {
         Message message = error.messageKind.message(error.messageArguments);
         generateRuntimeError(node.send, message.toString());
-      } else {
-        compiler.internalError('unexpected unresolved constructor call',
-                               node: node);
       }
     } else if (node.isConst()) {
       // TODO(karlklose): add type representation
       ConstantHandler handler = compiler.constantHandler;
       Constant constant = handler.compileNodeWithDefinitions(node, elements);
       stack.add(graph.addConstant(constant));
-    } else if (Elements.isMalformedElement(element)) {
-      Message message =
-          MessageKind.TYPE_VARIABLE_WITHIN_STATIC_MEMBER.message([element]);
-      generateRuntimeError(node.send, message.toString());
     } else {
-      visitNewSend(node.send, elements.getType(node));
+      DartType type = elements.getType(node);
+      if (compiler.enableTypeAssertions && type.isMalformed) {
+        ErroneousElement error;
+        type.forEachMalformedType((MalformedType malformedType) {
+          error = malformedType.element;
+          return false; // Visit the for malformed type only.

[ahe, 2012/11/30 15:44:07]

I'm not sure I understand this comment.

[Johnni Winther, 2012/12/04 10:07:17]

Changed to include all errors.

+        });
+        Message message = error.messageKind.message(error.messageArguments);
+        generateRuntimeError(node, message.toString());
+      } else {
+        visitNewSend(node.send, type);
+      }
     }
   }
 
   visitSendSet(SendSet node) {
     Element element = elements[node];
     if (!Elements.isUnresolved(element) && element.impliesType()) {
       Identifier selector = node.selector;
       generateThrowNoSuchMethod(node, selector.source.slowToString(),
                                 argumentNodes: node.arguments);
       return;
@@ skipping 1430 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }