tools/telemetry/telemetry/browser_finder.py - Issue 11412238: Proof of concept for running extension API stack through dev tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/browser_finder.py

Issue 11412238: Proof of concept for running extension API stack through dev tools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/browser_finder.py

diff --git a/tools/telemetry/telemetry/browser_finder.py b/tools/telemetry/telemetry/browser_finder.py

index afc7930864beb7de3aa2ef8dabe9f7790d436007..f75638db9c3f6ab4509cd2343f126b5947b959f4 100644

--- a/tools/telemetry/telemetry/browser_finder.py

+++ b/tools/telemetry/telemetry/browser_finder.py

@@ -53,7 +53,8 @@ def FindBrowser(options):

return None

matching_browsers = [b for b in browsers

- if b.browser_type == options.browser_type]

+ if b.browser_type == options.browser_type and

+ (len(options.extensions_to_load) == 0 or b.supports_extensions)]

if len(matching_browsers) == 1:

return matching_browsers[0]