Issue 11412233: Remove unused --save-downloads-dir option from download_toolchains.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412233: Remove unused --save-downloads-dir option from download_toolchains.py (Closed)

Created:
8 years ago by Sam Clegg

Modified:
8 years ago

Reviewers:
bradnelson, bradn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Remove unused --save-downloads-dir option download_toolchains.py. This option doesn't do anything. This option is currently used in the chrome DEPS file so will need to be removed from there first. BUG= Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10373

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	build/download_toolchains.py	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/sbc@chromium.org/11412233/1

8 years ago (2012-12-04 06:14:21 UTC) #3

Message was sent while issue was closed.

Change committed as 10373

Expand Messages | Collapse Messages