Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: src/messages.js

Issue 1141223002: [parser] report SyntaxError if rest parameter used in Setter MethodDefinition (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parser.cc » ('j') | test/message/rest-param-class-setter-strict.out » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.js
diff --git a/src/messages.js b/src/messages.js
index eb6e07fb07bdf6df49ead6f9288edf183127dae0..bb5789fd60a7ab84f3b964234b4cd03c4d3f9946 100644
--- a/src/messages.js
+++ b/src/messages.js
@@ -141,6 +141,7 @@ var kMessages = {
super_constructor_call: ["A 'super' constructor call may only appear as the first statement of a function, and its arguments may not access 'this'. Other forms are not yet supported."],
duplicate_proto: ["Duplicate __proto__ fields are not allowed in object literals"],
param_after_rest: ["Rest parameter must be last formal parameter"],
+ setter_rest_param: ["Setter function argument must not be a rest parameter"],
arv (Not doing code reviews) 2015/05/15 13:55:56 Can you use messages.h instead since Yang is in th
caitp (gmail) 2015/05/15 14:01:27 I'd like to, but it's not obvious how to make the
derived_constructor_return: ["Derived constructors may only return object or undefined"],
for_in_loop_initializer: ["for-in loop variable declaration may not have an initializer."],
for_of_loop_initializer: ["for-of loop variable declaration may not have an initializer."],
« no previous file with comments | « no previous file | src/parser.cc » ('j') | test/message/rest-param-class-setter-strict.out » ('J')

Powered by Google App Engine
This is Rietveld 408576698