[parser] report SyntaxError if rest parameter used in Setter MethodDefinition

src/messages.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // -------------------------------------------------------------------
 
 var $errorToString;
 var $formatMessage;
 var $getStackTraceLine;
 var $messageGetPositionInLine;
@@ skipping 123 matching lines @@
   strong_constructor_return_misplaced: ["In strong mode, returning from a constructor before its super constructor invocation or all assignments to 'this' is deprecated"],
   sloppy_lexical:                ["Block-scoped declarations (let, const, function, class) not yet supported outside strict mode"],
   malformed_arrow_function_parameter_list: ["Malformed arrow function parameter list"],
   module_export_undefined:       ["Export '", "%0", "' is not defined in module"],
   duplicate_export:              ["Duplicate export of '", "%0", "'"],
   unexpected_super:              ["'super' keyword unexpected here"],
   duplicate_constructor:         ["A class may only have one constructor"],
   super_constructor_call:        ["A 'super' constructor call may only appear as the first statement of a function, and its arguments may not access 'this'. Other forms are not yet supported."],
   duplicate_proto:               ["Duplicate __proto__ fields are not allowed in object literals"],
   param_after_rest:              ["Rest parameter must be last formal parameter"],
+  setter_rest_param:             ["Setter function argument must not be a rest parameter"],

[arv (Not doing code reviews), 2015/05/15 13:55:56]

Can you use messages.h instead since Yang is in the process of removing this
table from js.

[caitp (gmail), 2015/05/15 14:01:27]

I'd like to, but it's not obvious how to make the parser's ReportMessage
infrastructure use the new message stuff, which I think is why most of those
messages haven't been moved to that yet. The one SyntaxError which does use this
is part of a runtime function, which doesn't really apply to normal parsing.
Maybe yangguo could shed some light on this, I'll add them as a reviewer

   derived_constructor_return:    ["Derived constructors may only return object or undefined"],
   for_in_loop_initializer:       ["for-in loop variable declaration may not have an initializer."],
   for_of_loop_initializer:       ["for-of loop variable declaration may not have an initializer."],
   for_inof_loop_multi_bindings:  ["Invalid left-hand side in ", "%0", " loop: Must have a single binding."],
   bad_getter_arity:              ["Getter must not have any formal parameters."],
   bad_setter_arity:              ["Setter must have exactly one formal parameter."],
   this_formal_parameter:         ["'this' is not a valid formal parameter name"],
   duplicate_arrow_function_formal_parameter: ["Arrow function may not have duplicate parameter names"]
 };
 
@@ skipping 1061 matching lines @@
   return MakeGenericError(GlobalTypeError, type, [arg]);
 }
 
 //Boilerplate for exceptions for stack overflows. Used from
 //Isolate::StackOverflow().
 $stackOverflowBoilerplate = MakeRangeError(kStackOverflow);
 %DefineAccessorPropertyUnchecked($stackOverflowBoilerplate, 'stack',
                                  StackTraceGetter, StackTraceSetter, DONT_ENUM);
 
 })