mac: Get revision information from LASTCHANGE like windows and linux do

build/mac/tweak_info_plist.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 #
 # Xcode supports build variable substitutions and CPP; sadly, that doesn't work
 # because:
 #
@@ skipping 13 matching lines @@
 import os
 from os import environ as env
 import plistlib
 import re
 import subprocess
 import sys
 import tempfile
 
 TOP = os.path.join(env['SRCROOT'], '..')
 
-sys.path.insert(0, os.path.join(TOP, "build/util"))
-import lastchange
-
 
 def _GetOutput(args):
   """Runs a subprocess and waits for termination. Returns (stdout, returncode)
   of the process. stderr is attached to the parent."""
   proc = subprocess.Popen(args, stdout=subprocess.PIPE)
   (stdout, stderr) = proc.communicate()
   return (stdout, proc.returncode)
 
 
 def _GetOutputNoError(args):
@@ skipping 62 matching lines @@
 
   # Return with no error.
   return True
 
 
 def _DoSCMKeys(plist, add_keys):
   """Adds the SCM information, visible in about:version, to property list. If
   |add_keys| is True, it will insert the keys, otherwise it will remove them."""
   scm_revision = None
   if add_keys:
-    version_info = lastchange.FetchVersionInfo(
-        default_lastchange=None, directory=TOP)
-    scm_revision = version_info.revision
+    # Pull in the Chrome revision number.
+    VERSION_TOOL = os.path.join(TOP, 'chrome/tools/build/version.py')
+    LASTCHANGE_FILE = os.path.join(TOP, 'build/util/LASTCHANGE')
+    (stdout, retval) = _GetOutput([VERSION_TOOL, '-f', LASTCHANGE_FILE, '-t',
+                                  '@LASTCHANGE@'])
+    if retval:
+      return False
+    scm_revision = stdout.rstrip()
 
   # See if the operation failed.
   _RemoveKeys(plist, 'SCMRevision')
   if scm_revision != None:
     plist['SCMRevision'] = scm_revision
   elif add_keys:
     print >>sys.stderr, 'Could not determine SCM revision.  This may be OK.'
 
   # TODO(thakis): Remove this once m25 has reached stable.
   _RemoveKeys(plist, 'SCMPath')
+  return True
 
 
 def _DoPDFKeys(plist, add_keys):
   """Adds PDF support to the document types list. If add_keys is True, it will
   add the type information dictionary. If it is False, it will remove it if
   present."""
 
   PDF_FILE_EXTENSION = 'pdf'
 
   def __AddPDFKeys(sub_plist):
@@ skipping 133 matching lines @@
   # Only add Keystone in Release builds.
   if options.use_keystone and env['CONFIGURATION'] == 'Release':
     if options.bundle_identifier is None:
       print >>sys.stderr, 'Use of Keystone requires the bundle id.'
       return 1
     _AddKeystoneKeys(plist, options.bundle_identifier)
   else:
     _RemoveKeystoneKeys(plist)
 
   # Adds or removes any SCM keys.
-  _DoSCMKeys(plist, options.add_scm_info)
+  if not _DoSCMKeys(plist, options.add_scm_info):
+    return 3
 
   # Adds or removes the PDF file handler entry.
   _DoPDFKeys(plist, options.add_pdf_support)
 
   # Now that all keys have been mutated, rewrite the file.
   temp_info_plist = tempfile.NamedTemporaryFile()
   plistlib.writePlist(plist, temp_info_plist.name)
 
   # Info.plist will work perfectly well in any plist format, but traditionally
   # applications use xml1 for this, so convert it to ensure that it's valid.
   proc = subprocess.Popen(['plutil', '-convert', 'xml1', '-o', DEST_INFO_PLIST,
                            temp_info_plist.name])
   proc.wait()
   return proc.returncode
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv[1:]))