NTP5: Fine tuning of Apps implementation.

chrome/browser/resources/ntp_search/mock/mock.js

Index: chrome/browser/resources/ntp_search/mock/mock.js
diff --git a/chrome/browser/resources/ntp_search/mock/mock.js b/chrome/browser/resources/ntp_search/mock/mock.js
index 7b6485d6ef921bfbb7416f4fafa06af317323a2b..f1217b43a32c2342d66f1ead6908e07a5ac67fa7 100644
--- a/chrome/browser/resources/ntp_search/mock/mock.js
+++ b/chrome/browser/resources/ntp_search/mock/mock.js
@@ -17,6 +17,7 @@ var recordMockData = false;
 
   // Only messages registered in the callback map will be intercepted.
   var callbackMap = {
+    'appRemoved': 'ntp.appRemoved',
     'blacklistURLFromMostVisited': NO_CALLBACK,
     'clearMostVisitedURLsBlacklist': NO_CALLBACK,
     'getApps': 'ntp.getAppsCallback',
@@ -242,14 +243,17 @@ var recordMockData = false;
     },
 
     uninstallApp: function(id) {
+      var appData;
       var data = dataMap['getApps'][0].apps;
       for (var i = 0, length = data.length; i < length; i++) {
         if (data[i].id == id) {
+          appData = data[i];
           data.splice(i, 1);
           break;
         }
       }

[Dan Beam, 2012/11/30 23:41:45]

perhaps it doesn't matter if this is mock code, but should you assert(appData);
(that you found the app that's about to be removed)?

[pedro (no code reviews), 2012/12/01 00:02:29]

Done.

-      dispatchCallbackForMessage('getApps');
+      dataMap['appRemoved'] = [appData, true, true];
+      dispatchCallbackForMessage('appRemoved');
     },
   };