NTP5: Fine tuning of Apps implementation.

chrome/browser/resources/ntp_search/mock/mock.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // If you set this variable to true, then compile and run Chrome, all messages
 // sent with chrome.send() will be intercepted and their callback data will be
 // recorded. You can later see the recorded data by executing chrome.mock()
 // on Web Developer Tools' console.
 var recordMockData = false;
 
 (recordMockData || !/^chrome:\/\/./.test(location.href)) && (function() {
 
   var __chrome__ = chrome;
   var shouldRegisterData = !!window.chrome && !!window.chrome.send;
 
   var NO_CALLBACK = 1;
 
   // Only messages registered in the callback map will be intercepted.
   var callbackMap = {
+    'appRemoved': 'ntp.appRemoved',
     'blacklistURLFromMostVisited': NO_CALLBACK,
     'clearMostVisitedURLsBlacklist': NO_CALLBACK,
     'getApps': 'ntp.getAppsCallback',
     'getForeignSessions': 'ntp.setForeignSessions',
     'getMostVisited': 'ntp.setMostVisitedPages',
     'getRecentlyClosedTabs': 'ntp.setRecentlyClosedTabs',
     'metricsHandler:logEventTime': NO_CALLBACK,
     'metricsHandler:recordInHistogram': NO_CALLBACK,
     'removeURLsFromMostVisitedBlacklist': NO_CALLBACK,
     'uninstallApp': NO_CALLBACK,
@@ skipping 205 matching lines @@
       }
       dispatchCallbackForMessage('getMostVisited');
     },
 
     clearMostVisitedURLsBlacklist: function() {
       mostVisitedBlackList = {};
       dispatchCallbackForMessage('getMostVisited');
     },
 
     uninstallApp: function(id) {
+      var appData;
       var data = dataMap['getApps'][0].apps;
       for (var i = 0, length = data.length; i < length; i++) {
         if (data[i].id == id) {
+          appData = data[i];
           data.splice(i, 1);
           break;
         }
       }

[Dan Beam, 2012/11/30 23:41:45]

perhaps it doesn't matter if this is mock code, but should you assert(appData);
(that you found the app that's about to be removed)?

[pedro (no code reviews), 2012/12/01 00:02:29]

Done.

-      dispatchCallbackForMessage('getApps');
+      dataMap['appRemoved'] = [appData, true, true];
+      dispatchCallbackForMessage('appRemoved');
     },
   };
 
   //----------------------------------------------------------------------------
   // Debug
   //----------------------------------------------------------------------------
 
   var debugArgs = {
     debug: false,
     slownessFactor: null,
@@ skipping 86 matching lines @@
 
   //----------------------------------------------------------------------------
   // ChromeMock initialization
   //----------------------------------------------------------------------------
 
   if (shouldRegisterData)
     interceptLoadData();
 
   window.chrome = ChromeMock;
 })();