[sync] Componentize sync: Part Final: Target 'sync' is now its own component

sync/syncable/syncable_base_transaction.h

Index: sync/syncable/syncable_base_transaction.h
diff --git a/sync/syncable/syncable_base_transaction.h b/sync/syncable/syncable_base_transaction.h
index 763f68d15ae47c43352220b1986c95df2ea0ec43..6fcf2b9456c6016891ed09c055b199e921d4c447 100644
--- a/sync/syncable/syncable_base_transaction.h
+++ b/sync/syncable/syncable_base_transaction.h
@@ -1,4 +1,4 @@
-// Copyright 2012 The Chromium Authors. All rights reserved.
+// Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -31,7 +31,7 @@ enum WriterTag {
 // Make sure to update this if you update WriterTag.
 std::string WriterTagToString(WriterTag writer_tag);
 
-class SYNC_EXPORT_PRIVATE BaseTransaction {
+class SYNC_EXPORT BaseTransaction {

[tim (not reviewing), 2013/01/22 23:29:59]

Where do we use syncable transactions directly?  Should there be a todo here?

[Raghu Simha, 2013/01/23 03:43:46]

Good catch. I don't believe we use this class directly. I think I mistakenly
exported this because of linker errors on Windows due to the non-exported base
class of syncable::{Read|Write}Transaction. The right fix is to use
NON_EXPORTED_BASE while declaring the inheritance. I've removed this export.

  public:
   inline Directory* directory() const { return directory_; }
   inline Id root_id() const { return Id(); }