[sync] Componentize sync: Part Final: Target 'sync' is now its own component

sync/sync_core.gypi

Index: sync/sync_core.gypi
diff --git a/sync/sync_core.gypi b/sync/sync_core.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..5b43c5a1aa0d1baeb555ccc829aabbb7b1ea4daf
--- /dev/null
+++ b/sync/sync_core.gypi
@@ -0,0 +1,190 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'defines': [
+    'SYNC_IMPLEMENTATION',
+  ],
+  'include_dirs': [
+    '..',

[Ryan Sleevi, 2013/01/23 01:05:20]

style nit: You swapped the order of include_dirs and defines between
sync_api.gypi. You should keep the same ordering

[Raghu Simha, 2013/01/23 03:43:46]

Nice catch! Fixed.

+  ],
+  'dependencies': [
+    '../base/base.gyp:base',
+    '../base/base.gyp:base_i18n',
+    '../build/temp_gyp/googleurl.gyp:googleurl',
+    '../crypto/crypto.gyp:crypto',
+    '../google_apis/google_apis.gyp:google_apis',
+    '../net/net.gyp:net',
+    '../sql/sql.gyp:sql',
+  ],
+  'conditions': [
+    ['OS=="linux" and chromeos==1', {
+      # Required by get_session_name.cc on Chrome OS.
+      'dependencies': [
+        '../chromeos/chromeos.gyp:chromeos',
+      ],
+    }],
+  ],
+  'sources': [
+    'base/sync_export.h',
+    'engine/all_status.cc',
+    'engine/all_status.h',
+    'engine/apply_control_data_updates.cc',
+    'engine/apply_control_data_updates.h',
+    'engine/apply_updates_and_resolve_conflicts_command.cc',
+    'engine/apply_updates_and_resolve_conflicts_command.h',
+    'engine/backoff_delay_provider.cc',
+    'engine/backoff_delay_provider.h',
+    'engine/build_commit_command.cc',
+    'engine/build_commit_command.h',
+    'engine/commit.cc',
+    'engine/commit.h',
+    'engine/conflict_resolver.cc',
+    'engine/conflict_resolver.h',
+    'engine/conflict_util.cc',
+    'engine/conflict_util.h',
+    'engine/download_updates_command.cc',
+    'engine/download_updates_command.h',
+    'engine/get_commit_ids_command.cc',
+    'engine/get_commit_ids_command.h',
+    'engine/model_changing_syncer_command.cc',
+    'engine/model_changing_syncer_command.h',
+    'engine/net/server_connection_manager.cc',
+    'engine/net/server_connection_manager.h',
+    'engine/net/url_translator.cc',
+    'engine/net/url_translator.h',
+    'engine/nudge_source.cc',
+    'engine/nudge_source.h',
+    'engine/process_commit_response_command.cc',
+    'engine/process_commit_response_command.h',
+    'engine/process_updates_command.cc',
+    'engine/process_updates_command.h',
+    'engine/store_timestamps_command.cc',
+    'engine/store_timestamps_command.h',
+    'engine/sync_engine_event.cc',
+    'engine/sync_engine_event.h',
+    'engine/sync_scheduler.cc',
+    'engine/sync_scheduler.h',
+    'engine/sync_scheduler_impl.cc',
+    'engine/sync_scheduler_impl.h',
+    'engine/sync_session_job.cc',
+    'engine/sync_session_job.h',
+    'engine/syncer.cc',
+    'engine/syncer.h',
+    'engine/syncer_command.cc',
+    'engine/syncer_command.h',
+    'engine/syncer_proto_util.cc',
+    'engine/syncer_proto_util.h',
+    'engine/syncer_types.h',
+    'engine/syncer_util.cc',
+    'engine/syncer_util.h',
+    'engine/throttled_data_type_tracker.cc',
+    'engine/throttled_data_type_tracker.h',
+    'engine/traffic_logger.cc',
+    'engine/traffic_logger.h',
+    'engine/traffic_recorder.cc',
+    'engine/traffic_recorder.h',
+    'engine/update_applicator.cc',
+    'engine/update_applicator.h',
+    'js/js_arg_list.cc',
+    'js/js_arg_list.h',
+    'js/js_backend.h',
+    'js/js_controller.h',
+    'js/js_event_details.cc',
+    'js/js_event_details.h',
+    'js/js_event_handler.h',
+    'js/js_reply_handler.h',
+    'js/sync_js_controller.cc',
+    'js/sync_js_controller.h',
+    'protocol/proto_enum_conversions.cc',

[tim (not reviewing), 2013/01/22 23:29:59]

Should these be part of sync_proto, or not (since they're not .proto files)?

[Raghu Simha, 2013/01/23 03:43:46]

I believe they should stay here, because sync_proto.gypi includes protoc.gypi,
which contains rules for compiling .proto files into h/cc files. The rules are
applied on all files in the sources section of sync_proto.gypi. See the comments
at the top of build/protoc.gypi. Also, there is no precedent elsewhere in the
chrome codebase for including non-proto files in a *_proto.gypi file.

+    'protocol/proto_enum_conversions.h',
+    'protocol/proto_value_conversions.cc',
+    'protocol/proto_value_conversions.h',
+    'protocol/sync_protocol_error.cc',
+    'protocol/sync_protocol_error.h',
+    'sessions/debug_info_getter.h',
+    'sessions/ordered_commit_set.cc',
+    'sessions/ordered_commit_set.h',
+    'sessions/status_controller.cc',
+    'sessions/status_controller.h',
+    'sessions/sync_session.cc',
+    'sessions/sync_session.h',
+    'sessions/sync_session_context.cc',
+    'sessions/sync_session_context.h',
+    'syncable/blob.h',
+    'syncable/delete_journal.cc',
+    'syncable/delete_journal.h',
+    'syncable/dir_open_result.h',
+    'syncable/directory.cc',
+    'syncable/directory.h',
+    'syncable/directory_backing_store.cc',
+    'syncable/directory_backing_store.h',
+    'syncable/directory_change_delegate.h',
+    'syncable/entry.cc',
+    'syncable/entry.h',
+    'syncable/entry_kernel.cc',
+    'syncable/entry_kernel.h',
+    'syncable/in_memory_directory_backing_store.cc',
+    'syncable/in_memory_directory_backing_store.h',
+    'syncable/invalid_directory_backing_store.cc',
+    'syncable/invalid_directory_backing_store.h',
+    'syncable/metahandle_set.h',
+    'syncable/model_type.cc',
+    'syncable/mutable_entry.cc',
+    'syncable/mutable_entry.h',
+    'syncable/nigori_handler.cc',
+    'syncable/nigori_handler.h',
+    'syncable/nigori_util.cc',
+    'syncable/nigori_util.h',
+    'syncable/on_disk_directory_backing_store.cc',
+    'syncable/on_disk_directory_backing_store.h',
+    'syncable/scoped_kernel_lock.h',
+    'syncable/syncable-inl.h',
+    'syncable/syncable_base_transaction.cc',
+    'syncable/syncable_base_transaction.h',
+    'syncable/syncable_changes_version.h',
+    'syncable/syncable_columns.h',
+    'syncable/syncable_enum_conversions.cc',
+    'syncable/syncable_enum_conversions.h',
+    'syncable/syncable_id.cc',
+    'syncable/syncable_id.h',
+    'syncable/syncable_proto_util.cc',
+    'syncable/syncable_proto_util.h',
+    'syncable/syncable_read_transaction.cc',
+    'syncable/syncable_read_transaction.h',
+    'syncable/syncable_util.cc',
+    'syncable/syncable_util.h',
+    'syncable/syncable_write_transaction.cc',
+    'syncable/syncable_write_transaction.h',
+    'syncable/transaction_observer.h',
+    'syncable/write_transaction_info.cc',
+    'syncable/write_transaction_info.h',
+    'util/cryptographer.cc',
+    'util/cryptographer.h',
+
+    # TODO(akalin): Figure out a better place to put
+    # data_encryption_win*; it's also used by autofill.
+    'util/data_encryption_win.cc',
+    'util/data_encryption_win.h',
+
+    'util/data_type_histogram.h',
+    'util/encryptor.h',
+    'util/extensions_activity_monitor.cc',
+    'util/extensions_activity_monitor.h',
+    'util/get_session_name.cc',
+    'util/get_session_name.h',
+    'util/get_session_name_ios.mm',
+    'util/get_session_name_ios.h',
+    'util/get_session_name_mac.mm',
+    'util/get_session_name_mac.h',
+    'util/get_session_name_win.cc',
+    'util/get_session_name_win.h',
+    'util/logging.cc',
+    'util/logging.h',
+    'util/nigori.cc',
+    'util/nigori.h',
+    'util/time.cc',
+    'util/time.h',
+  ],
+}