sync/base/sync_export.h - Issue 11412211: [sync] Componentize sync: Part Final: Target 'sync' is now its own component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/base/sync_export.h

Issue 11412211: [sync] Componentize sync: Part Final: Target 'sync' is now its own component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase + merge with net->sync dependency fix (no code changes) Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/base/sync_export.h

diff --git a/sync/base/sync_export.h b/sync/base/sync_export.h

index a38e8b23a365e01b1bee96c4985e07fa6f28a740..59dfca2b5e4cf55afcc550f7631e84ff8006f2df 100644

--- a/sync/base/sync_export.h

+++ b/sync/base/sync_export.h

@@ -1,12 +1,11 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

#ifndef SYNC_SYNC_EXPORT_H_

#define SYNC_SYNC_EXPORT_H_

-// TODO(akalin): Remove '0 && ' when sync becomes a component.

-#if 0 && defined(COMPONENT_BUILD)

+#if defined(COMPONENT_BUILD)

tim (not reviewing) 2013/01/22 23:29:59 Can we add a comment here that explains when to us

Raghu Simha 2013/01/23 03:43:46 Done.

#if defined(WIN32)

#if defined(SYNC_IMPLEMENTATION)

« chrome/chrome_browser.gypi ('K') | « jingle/jingle.gyp ('k') | sync/internal_api/public/base/unique_position.h » ('j') | sync/sync.gyp » ('J')