third_party/protobuf/README.chromium - Issue 11412211: [sync] Componentize sync: Part Final: Target 'sync' is now its own component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/README.chromium

Issue 11412211: [sync] Componentize sync: Part Final: Target 'sync' is now its own component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address CR Feedback Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/protobuf/README.chromium

diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium

index 767241178cb21420eeccf2455b0ec3a271f314bc..211014f7d775e0368a3404fdec035433c54a740d 100644

--- a/third_party/protobuf/README.chromium

+++ b/third_party/protobuf/README.chromium

@@ -14,7 +14,10 @@ descriptor2_pb.py

protobuf_lite_java_descriptor_proto.py

protobuf_lite_java_parse_pom.py

-A protobuf.gyp file has been added for building with Chromium.

+A protobuf.gyp file has been added for building with Chromium. It was updated to

+support component builds on Windows by adding the required export definitions.

+See rXXXXXX for the patch.

+TODO(rsimha): Update revision number above after this CL is landed.

This code has been patched to support unknown field retention in protobuf-lite.

See r62331 for the patch.

« sync/sync.gyp ('K') | « sync/syncable/syncable_write_transaction.h ('k') | third_party/protobuf/protobuf.gyp » ('j') | no next file with comments »