Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/protobuf/protobuf.gyp

Issue 11412211: [sync] Componentize sync: Part Final: Target 'sync' is now its own component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Component build working on all platforms Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/net.gyp ('K') | « third_party/protobuf/README.chromium ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/protobuf.gyp
diff --git a/third_party/protobuf/protobuf.gyp b/third_party/protobuf/protobuf.gyp
index be94ee868877eb233ccf013431187ef10e8000cd..6b82f970bf3adc52d56041eec327188d81be7529 100644
--- a/third_party/protobuf/protobuf.gyp
+++ b/third_party/protobuf/protobuf.gyp
@@ -1,4 +1,4 @@
-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Copyright 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -192,6 +192,20 @@
'GOOGLE_PROTOBUF_NO_RTTI',
'GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER',
],
+ # On Win component builds, we must dynamically link protobuf_lite
+ # to targets that directly depend on it in order to avoid linker
+ # warning C4275: "non dll-interface class used as base for
+ # dll-interface class". See the "DLLs vs. static linking" section in
+ # third_party/protobuf/vsprojects/readme.txt.
+ 'conditions': [
+ ['OS=="win" and component=="shared_library"', {
+ 'defines': [
+ 'LIBPROTOBUF_EXPORTS',
+ 'LIBPROTOC_EXPORTS',
+ 'PROTOBUF_USE_DLLS',
+ ],
+ }],
+ ],
},
},
# This is the full, heavy protobuf lib that's needed for c++ .proto's
« net/net.gyp ('K') | « third_party/protobuf/README.chromium ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698