[sync] Componentize sync: Part Final: Target 'sync' is now its own component

net/net.gyp

-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
 
     'linux_link_kerberos%': 0,
     'conditions': [
       ['chromeos==1 or OS=="android" or OS=="ios"', {
@@ skipping 1883 matching lines @@
         'url_request/test_url_fetcher_factory.h',
         'url_request/url_request_test_util.cc',
         'url_request/url_request_test_util.h',
       ],
       'conditions': [
         ['inside_chromium_build==1 and OS != "ios"', {
           'dependencies': [
             # The test server uses Python modules generated by cloud print.
             # TODO(sync): Remove this hack (http://crbug.com/119403).
             '../chrome/app/policy/cloud_policy_codegen.gyp:cloud_policy_proto_compile',
-            # The test server uses Python modules generated by the sync protos.
-            # TODO(sync): Remove this hack (http://crbug.com/117559).
-            '../sync/protocol/sync_proto.gyp:sync_proto',

[akalin, 2013/01/07 20:14:51]

i'm pretty sure this is still needed, unless something has changed.  The trybots
may pass, but there might not be coverage.  Basically, this was needed because
the net testserver depended on sync protos for the sync server parts; without
this, the net testserver was failing because it was trying to include the proto
files even when the sync server wasn't being used.  Has that changed?

[Raghu Simha, 2013/01/08 11:27:48]

You're right that this used to be the case. However, we now lazily import
chromiumsync.py in testserver.py when a sync testserver is being used. Test
suites that use a non-sync testserver remain unaffected by this change, and
suites that do use a sync testserver already depend on sync.gyp:sync_proto.

The reason I had to remove this dependency is that with component builds, the
sync_proto target had to be moved out of its own separate gyp file and into
sync.gyp, which created a cycle in the gyp dependency graph between net.gyp and
sync.gyp (gyp cycles are detected at the file level, and not at the target
level). I tried a whole bunch of gyp file hackery, but none of it was able to
remove the cycle.

In any case, it is my intent to fix crbug.com/117559 soon. Until then, the only
thing that breaks is run_testserver, and only if you were to build it without
building sync_proto, and then run it with the --sync flag. I've added a message
in run_testserver.cc to warn users of this until the bug is fixed. Let me know
if this sounds good.

[Ryan Sleevi, 2013/01/08 19:16:12]

At the risk of piling on, I would prefer you fix that issue first. Such
dependency hackery is subtle for users, subtle to debug, and worse, may
intermittently cause flakes.

[Raghu Simha, 2013/01/22 09:25:41]

With http://crrev.com/177864, the above comment can be disregarded as moot.
There is no longer a dependency between net.gyp and sync.gyp.

             '../third_party/protobuf/protobuf.gyp:py_proto',
           ],
         }],
         ['os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', {
           'conditions': [
             ['use_openssl==1', {
               'dependencies': [
                 '../third_party/openssl/openssl.gyp:openssl',
               ],
             }, {
@@ skipping 480 matching lines @@
                 '--result', '<@(_outputs)',
                 '--isolate', 'net_unittests.isolate',
               ],
             },
           ],
         },
       ],
     }],
   ],
 }