[sync] Componentize sync: Part Final: Target 'sync' is now its own component

chrome/chrome_browser_extensions.gypi

-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser_extensions',
       'type': 'static_library',
       'variables': { 'enable_wexit_time_destructors': 1, },
       # Since browser and browser_extensions actually depend on each other,
       # we must omit the dependency from browser_extensions to browser.
       # However, this means browser_extensions and browser should more or less
       # have the same dependencies. Once browser_extensions is untangled from
       # browser, then we can clean up these dependencies.
       'dependencies': [
-        '../sync/protocol/sync_proto.gyp:sync_proto',
         'chrome_resources.gyp:chrome_extra_resources',
         'chrome_resources.gyp:chrome_resources',
         'chrome_resources.gyp:chrome_strings',
         'chrome_resources.gyp:platform_locale_settings',
         'chrome_resources.gyp:theme_resources',
         'common',
         'common/extensions/api/api.gyp:api',
         'common_net',
         'contacts_proto',
         'debugger',
         'in_memory_url_index_cache_proto',
         'installer_util',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../content/content.gyp:content_browser',
         '../crypto/crypto.gyp:crypto',
         '../device/device.gyp:device_bluetooth',
         '../net/net.gyp:net',
         '../skia/skia.gyp:skia',
         '../sync/sync.gyp:sync_notifier',
+        '../sync/sync.gyp:sync_proto',
         '../third_party/bzip2/bzip2.gyp:bzip2',
+        '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',

[akalin, 2013/01/07 20:14:51]

just curious, where's the direct dep on cacheinvalidation?

[Raghu Simha, 2013/01/08 11:27:48]

chrome/browser/api/push_messaging/push_message_invalidation_handler.cc includes
google/cacheinvalidation/types.pb.h.

Come to think of it, so does
chrome/browser/api/push_messaging/push_message_invalidation_handler_unittest.cc,
so I'll need to add the dependency to browser_tests too. Done.

         '../third_party/icu/icu.gyp:icui18n',
         '../third_party/icu/icu.gyp:icuuc',
         '../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
         '../third_party/libusb/libusb.gyp:libusb',
         '../third_party/re2/re2.gyp:re2',
         '../ui/base/strings/ui_strings.gyp:ui_strings',
         '../ui/ui.gyp:ui',
         '../ui/ui.gyp:ui_resources',
         '../webkit/support/webkit_support.gyp:glue',
         '../webkit/support/webkit_support.gyp:user_agent',
@@ skipping 910 matching lines @@
           'msvs_settings': {
             'VCLinkerTool': {
               'SubSystem': '2',  # Set /SUBSYSTEM:WINDOWS
             },
           },
         },
       ],
     }, ],  # 'OS=="win"'
   ],  # 'conditions'
 }