Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: Source/WebKit/chromium/ChangeLog

Issue 11412177: Merge 135316 - When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 2012-11-20 Tony Chang <tony@chromium.org>
2
3 When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
4 https://bugs.webkit.org/show_bug.cgi?id=102835
5
6 Reviewed by Ojan Vafai.
7
8 After r135082, Chromium browser_tests were triggering the ASSERT in
9 StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
10 trigger earlier and make it clear in the Chromium code that we're always
11 inserting user level styles.
12
13 * src/WebDocument.cpp:
14 (WebKit::WebDocument::insertUserStyleSheet):
15
1 2012-11-08 Keishi Hattori <keishi@webkit.org> 16 2012-11-08 Keishi Hattori <keishi@webkit.org>
2 17
3 WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close 18 WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
4 https://bugs.webkit.org/show_bug.cgi?id=93800 19 https://bugs.webkit.org/show_bug.cgi?id=93800
5 20
6 Reviewed by Kent Tamura. 21 Reviewed by Kent Tamura.
7 22
8 We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent. 23 We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.
9 24
10 * src/WebPagePopupImpl.cpp: 25 * src/WebPagePopupImpl.cpp:
(...skipping 2409 matching lines...) Expand 10 before | Expand all | Expand 10 after
2420 2435
2421 [Chromium-Win] Implement LocaleWin::dateFormat 2436 [Chromium-Win] Implement LocaleWin::dateFormat
2422 https://bugs.webkit.org/show_bug.cgi?id=98117 2437 https://bugs.webkit.org/show_bug.cgi?id=98117
2423 2438
2424 Reviewed by Kentaro Hara. 2439 Reviewed by Kentaro Hara.
2425 2440
2426 * tests/LocaleWinTest.cpp: 2441 * tests/LocaleWinTest.cpp:
2427 (TEST_F): Add tests for LocaleWin::dateFormat. 2442 (TEST_F): Add tests for LocaleWin::dateFormat.
2428 2443
2429 == Rolled over to ChangeLog-2012-10-02 == 2444 == Rolled over to ChangeLog-2012-10-02 ==
OLDNEW
« no previous file with comments | « Source/WebCore/dom/DocumentStyleSheetCollection.cpp ('k') | Source/WebKit/chromium/src/WebDocument.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698